[css] Fix breaking layout breaking error in code block#28328
Merged
Conversation
Contributor
Author
Member
|
Please retarget against master. |
Was before: word-break: break-word; Should be (in my Opinion): word-wrap: break-word;
Contributor
Author
|
Done: retarget to master branch |
Member
|
Friendly ping @twbs/css-review |
MartijnCuppens
approved these changes
Jul 15, 2019
Member
|
Should this be backported to v4? |
Contributor
Author
|
I think that would be great since not everyone will upgrade existing v4 projects... |
Member
|
Nah, if we are going to backport it, I'll cherrypick it. |
Member
Yup, it's a bug |
XhmikosR
pushed a commit
that referenced
this pull request
Jul 16, 2019
Change `word-break: break-word;` to `word-wrap: break-word;`
XhmikosR
pushed a commit
that referenced
this pull request
Jul 17, 2019
Change `word-break: break-word;` to `word-wrap: break-word;`
XhmikosR
pushed a commit
that referenced
this pull request
Jul 17, 2019
Change `word-break: break-word;` to `word-wrap: break-word;`
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Code block does not break long lines
see miminal example
Was before:
word-break: break-word;Should be (in my Opinion):
word-wrap: break-word;