accessibility - add aria-disabled on all disabled links#28305
Merged
Conversation
XhmikosR
previously requested changes
Feb 19, 2019
XhmikosR
left a comment
Member
There was a problem hiding this comment.
Please rebase your branch and drop any unrelated patches.
7019fbe to
ddf7459
Compare
ddf7459 to
0f3c59a
Compare
Contributor
Author
|
Yes sorry, haven't seen that my PR was corrupted. Think latest one was good |
patrickhlauke
approved these changes
Feb 19, 2019
patrickhlauke
left a comment
Member
There was a problem hiding this comment.
looks good to me. strangely, i could have sworn we did something like this already not so long ago?
Contributor
Author
|
Yes we already did it : #28051 |
Member
|
@patrickhlauke: yeah for examples only it seems 8eb8b8d |
Member
|
ah i see, this washes up stuff we missed previously. as you were :) |
XhmikosR
pushed a commit
that referenced
this pull request
Mar 1, 2019
XhmikosR
pushed a commit
that referenced
this pull request
Mar 7, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick fix on documentation to add tabindex="-1" and aria-disabled="true" on visually disabled link
cc @patrickhlauke for validation