Skip to content

Reset padding of .form-control-plaintext#28208

Merged
XhmikosR merged 6 commits into
twbs:masterfrom
ysds:readonly-plaintext-padding
May 9, 2019
Merged

Reset padding of .form-control-plaintext#28208
XhmikosR merged 6 commits into
twbs:masterfrom
ysds:readonly-plaintext-padding

Conversation

@ysds

@ysds ysds commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

I found this issue during test of #28205. iOS Safari input has padding by default.

Chrome etc:

image

iOS Safari:

image

This PR resets the padding for cross browser consistency.

@ysds ysds requested a review from a team as a code owner February 8, 2019 09:07
@ysds ysds changed the title Reset input padding for cross browser consistency Reset padding of .form-control-plaintext Feb 8, 2019
@XhmikosR XhmikosR added the css label Feb 8, 2019
@mdo

mdo commented Feb 14, 2019

Copy link
Copy Markdown
Member

Currently planning for this as part of a v4.3.2 release, so if this does ship, we'll want to cherry-pick this into our master branch for v5.

@XhmikosR XhmikosR changed the base branch from v4-dev to master February 19, 2019 12:38
@XhmikosR XhmikosR force-pushed the readonly-plaintext-padding branch from 24c133c to 0220204 Compare February 19, 2019 12:39
@XhmikosR

Copy link
Copy Markdown
Member

Changed base branch, marked it for backport.

@XhmikosR XhmikosR merged commit 06635be into twbs:master May 9, 2019
@mdo mdo mentioned this pull request Jul 22, 2019
@ysds ysds deleted the readonly-plaintext-padding branch March 2, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants