Skip to content

use callout without custom jekyll plugin#25320

Merged
XhmikosR merged 2 commits intotwbs:v4-devfrom
m5o:jekyll-callout
Mar 12, 2018
Merged

use callout without custom jekyll plugin#25320
XhmikosR merged 2 commits intotwbs:v4-devfrom
m5o:jekyll-callout

Conversation

@m5o
Copy link
Contributor

@m5o m5o commented Jan 15, 2018

  • use callout without custom jekyll plugin

🔗 #25319

mdo
mdo approved these changes Jan 16, 2018
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more verbose, but I appreciate the removal of a plugin.

@m5o
Copy link
Contributor Author

m5o commented Jan 16, 2018

@mdo What do you think of write the trailing as an one-liner:

{% endcapture %}{% include callout.html content=callout type="danger" %}

@XhmikosR
Copy link
Member

XhmikosR commented Jan 16, 2018

@mdo: I'd like to review the build-related PRs, so please CC me.

I'll test this and the other one that I haven't tested and comment when I have some time.

@XhmikosR
Copy link
Member

XhmikosR commented Jan 19, 2018

Haven't had the time to test this one and #25334, but have you seen any changes in build time?

I'm not sure what to expect since Ruby is just slow for some cases.

@m5o m5o force-pushed the jekyll-callout branch 2 times, most recently from 5c470a2 to e7c23b8 Compare January 20, 2018 16:14
@m5o m5o force-pushed the jekyll-callout branch 3 times, most recently from cbff46c to db8b1a0 Compare January 28, 2018 21:06
@XhmikosR XhmikosR self-assigned this Jan 31, 2018
@m5o
Copy link
Contributor Author

m5o commented Feb 12, 2018

@XhmikosR Can I support or help you with something to push this thought the finish line?

@XhmikosR
Copy link
Member

XhmikosR commented Feb 14, 2018

@m5o: I haven't forgot about it, I just haven't got the time to review your PRs yet.

Bear with me, and I'll get to it soon-ish :)

@m5o m5o mentioned this pull request Mar 5, 2018
Merged
@m5o
Copy link
Contributor Author

m5o commented Mar 8, 2018

@XhmikosR I'am very close to present a solution to get rid of the last custom plugin for building the toc. This PR is currently blocking me. I have to do minor markup change in the callout includes and don't want to do it twice. Please don't forget me :o)

@m5o m5o force-pushed the jekyll-callout branch from 3304925 to 6115b0d Compare March 8, 2018 16:16
@XhmikosR
Copy link
Member

XhmikosR commented Mar 8, 2018

I won't. But personally, I'm against dropping the Jekyll plugin for TOC.

We will never build on GH automatically so it makes no sense. What it makes sense is to try to speed things up if possible.

@XhmikosR XhmikosR removed the on-hold label Mar 12, 2018
@XhmikosR XhmikosR force-pushed the jekyll-callout branch 2 times, most recently from 84eae69 to 6ebc4cc Compare March 12, 2018 19:27
@mdo mdo mentioned this pull request Mar 12, 2018
Closed
@XhmikosR XhmikosR merged commit 836de9c into twbs:v4-dev Mar 12, 2018
@m5o m5o deleted the jekyll-callout branch March 12, 2018 20:38
@m5o m5o mentioned this pull request Mar 13, 2018
Closed
m5o added a commit to m5o/bootstrap that referenced this pull request Jan 7, 2019
@m5o
remove unused plugins from docs
6a3432a 
* twbs#25319
* twbs#25320
* twbs#25784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

Assignees

@XhmikosR XhmikosR

Labels

build v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m5o @XhmikosR @mdo