Add Wall of Browser Bugs entries for Selectors Level 4 :nth-child(An+B of S)#20143
Merged
Conversation
Collaborator
|
👍 With regards to the feature: Is it backwards compatible? I presume it isn't. |
Collaborator
Author
|
AIUI, it isn't. We'd probably only be able to use it in the far future when IE has been dropped completely. But I think we'd like this feature to be ready by the time that world arrives. |
Collaborator
Author
|
@patrickhlauke @XhmikosR LGTY? |
Member
|
LGTM although I do feel it's a little early but it doesn't hurt. |
cvrebert
added a commit
that referenced
this pull request
Jun 22, 2016
Add Wall of Browser Bugs entries for Selectors Level 4 :nth-child() (#20143) Refs http://caniuse.com/#feat=css-nth-child-of Refs https://drafts.csswg.org/selectors-4/#the-nth-child-pseudo Refs https://crbug.com/304163 Refs https://bugzil.la/854148 [skip sauce]
twbs-savage
pushed a commit
to twbs-savage/bootstrap
that referenced
this pull request
Sep 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose adding these on the grounds that the
of Sfeature would allow us to make our widgets more robust. We've had several issue reports (e.g. #15684, #13825, #16540) where folks tried to put stuff like<input type="hidden">within.input-groupor.btn-group, but this broke the:first-child/:last-child-based selectors we use to adjust rounded corners.With this feature, we could restrict the children considered to only the relevant ones, thus ignoring other irrelevant elements. For example, we could use
:nth-child(1 of .btn)in our.btn-groupCSS to ignore non-.btnchildren and thus round the corners correctly in such cases.Refs:
CC: @twbs/team for review