Conversation
scss/_forms.scss
Outdated
There was a problem hiding this comment.
Selector _ should be written in lowercase with hyphens
There was a problem hiding this comment.
Tweaked the SCSS-Lint config to squelch this. It was trying to enforce the dash-separated-words naming convention on element names in addition to class names.
|
This hit a minor SCSS-Lint bug. Opened a PR to fix it: sds/scss-lint#672 |
0e44c77 to
126f94e
Compare
|
Wow, awesome hack if it works. Mad props for spending time on this dude. |
…nment of temporal input text in iOS Safari See http://browserbu.gs/css-hacks/webkit-full-page-media/ Fixes #17308 [skip sauce] [skip validator]
|
Added a lint exemption comment to work around the SCSS-Lint bug. |
Switch to actually-Safari-specific CSS hack for iOS temporal input fix
|
Confirming that this also fixes the issue in Edge (and the inputs are exactly the same height as other text inputs) |
Filed #18842. |
|
Also, turns out OS X Safari is (still) bugged: #18843 |
Fixes #17308.
Research backing up this hack: http://browserbu.gs/css-hacks/webkit-full-page-media/
Chrome screenshot with the patch applied (temporal inputs are no longer super-tall):
iOS 9 Safari screenshot with the patch applied (text in temporal inputs is still vertically centered (at least by eyeball)):
The heights of
datetime-localdate,month,week, andtimeinputs in Chrome now become 40px, which is still different from the 38px height of the other textual inputs, but that particular discrepancy isn't caused by the iOS CSS that we're fixing here. Will open a new issue for that.There is some slight redundancy in the generated selectors, but it doesn't affect the potency of the hack. Here's what I mean:
I couldn't find a way in Sass, when nesting is involved, to tack a selector onto a selector list without it getting cross-producted with the nestees. Perhaps there's some particular Sass judo I don't know about.
CC: @mdo