Skip to content

update "is jQuery defined" check for UMD compatibility#13842

Merged
cvrebert merged 1 commit intomasterfrom
fix-13811
Jun 18, 2014
Merged

update "is jQuery defined" check for UMD compatibility#13842
cvrebert merged 1 commit intomasterfrom
fix-13811

Conversation

@cvrebert
Copy link
Collaborator

Addresses #13811, although the tests mentioned in that issue also need to be added.
/cc @fat

@cvrebert cvrebert added this to the v3.2.0 milestone Jun 17, 2014
@cvrebert cvrebert added the js label Jun 17, 2014
@XhmikosR
Copy link
Member

@cvrebert: you forgot https://github.com/twbs/bootstrap/blob/master/docs/assets/js/_src/customizer.js#L309

See, that's why I had mentioned back then that we should have that code in one place :)

@XhmikosR XhmikosR mentioned this pull request Jun 17, 2014
@cvrebert
Copy link
Collaborator Author

@XhmikosR Fixed. And noted that pitfall for future reference in 85c15ee.

@XhmikosR
Copy link
Member

Thanks, that should do the job for now.

cvrebert added a commit that referenced this pull request Jun 18, 2014
update "is jQuery defined" check for UMD compatibility
@cvrebert cvrebert merged commit 1c42dfc into master Jun 18, 2014
@cvrebert cvrebert deleted the fix-13811 branch June 18, 2014 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants