Skip to content

Reorganize test files#12291

Closed
zlatanvasovic wants to merge 1 commit intotwbs:masterfrom
zlatanvasovic:to
Closed

Reorganize test files#12291
zlatanvasovic wants to merge 1 commit intotwbs:masterfrom
zlatanvasovic:to

Conversation

@zlatanvasovic
Copy link

This reorganizes test files a bit. Only problem with test files is the browserstack.json — it must be in root.

@cvrebert
Copy link
Collaborator

So, what's the reason for renaming the directory?

@zlatanvasovic
Copy link
Author

-infra doesn't have sense for sause_browsers.yml?

@cvrebert
Copy link
Collaborator

Could make sense to move that file to /js/tests/

@zlatanvasovic
Copy link
Author

Hm. Possible. But test is nicer (shorter) name. ;)

Delay this for next release so we can discuss further.

2014/1/19 Chris Rebert notifications@github.com

Could make sense to move that file to /js/tests/


Reply to this email directly or view it on GitHubhttps://github.com//pull/12291#issuecomment-32718241
.

Zlatan Vasović - ZDroid

@zlatanvasovic
Copy link
Author

@cvrebert Is this ok (not for 3.1.0):

/
- tests/ (test/ is also ok)
-- js/ (move all the js test files there, so we don't need to worry about ignoring in bower.json)
-- css/ (move lint files from less/ so no need for filling up less/)
-- infra/ (move s3 files)
-- sauce_browsers.yml (directly in tests/ root)

Thoughts?

@mdo
Copy link
Member

mdo commented Jan 23, 2014

I'm meh on reorganizing any of this in v3.x. Maybe renaming test-infra, but not down with any of the other changes until v4. I'll make a note of that in our tracking issue.

@mdo mdo closed this Jan 23, 2014
@zlatanvasovic
Copy link
Author

Thanks.

2014/1/23 Mark Otto notifications@github.com

Closed #12291 #12291.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12291
.

Zlatan Vasović - ZDroid

@zlatanvasovic zlatanvasovic deleted the to branch January 23, 2014 07:20
@mdo mdo mentioned this pull request Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants