refactor(status): extract view height padding helper#606
Merged
Conversation
65f3331 to
92c2244
Compare
92c2244 to
78fe1d1
Compare
tw93
approved these changes
Mar 20, 2026
Owner
There was a problem hiding this comment.
LGTM
@FelixLyfe I pulled in latest main and resolved the merge conflict in cmd/status/main.go. I kept the current main branch view structure, including the full-height padding logic, and reapplied the read-only high-CPU alert bar on top of it. The branch is pushed and the PR is mergeable again.
I also re-ran go test for cmd/status after resolving the conflict, and it passed.
Contributor
|
太棒了
Tw93 ***@***.***> 于2026年3月21日周六 08:03写道：
… ***@***.**** approved this pull request.
LGTM
@FelixLyfe <https://github.com/FelixLyfe> I pulled in latest main and
resolved the merge conflict in cmd/status/main.go. I kept the current main
branch view structure, including the full-height padding logic, and
reapplied the read-only high-CPU alert bar on top of it. The branch is
pushed and the PR is mergeable again.
I also re-ran go test for cmd/status after resolving the conflict, and it
passed.
—
Reply to this email directly, view it on GitHub
<#606?email_source=notifications&email_token=AMKKIALDBD3N2Q66345PMKT4RXL33A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTGOJYGQ2DOMRUHEZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-3984472492>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKKIAOZ5C36BMNYUYYXSAL4RXL33AVCNFSM6AAAAACWY64R5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSOBUGQ3TENBZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the terminal-height padding logic in
mo statusinto a dedicated helper.The ghost-line fix itself has already landed via #601. This PR now keeps the helper-style refactor on top of the merged implementation.
What changed
padViewToHeight(view, height)incmd/status/main.goView()with the helperTests
go test ./cmd/status