Skip to content

feat: add tutor request form#266

Merged
nicholaschiang merged 10 commits intodevelopfrom
request
Oct 28, 2021
Merged

feat: add tutor request form#266
nicholaschiang merged 10 commits intodevelopfrom
request

Conversation

@nicholaschiang
Copy link
Copy Markdown
Member

@nicholaschiang nicholaschiang commented Oct 27, 2021

Fixes TB-149

@linear
Copy link
Copy Markdown

linear bot commented Oct 27, 2021

TB-149 Add student "tutor request" form

Students (or their parents) should be able to fill out a "request a tutor" form that creates an account for them and notifies org admins that they need a tutor.

Org admins will then open that email, click on a "Find them a tutor" button (that opens the users page with filters already selected and visible), and book a meeting with a tutor for them (i.e. using the "Select students" field and searching for the student).

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tutorbook/tutorbook/52vvC1BzbZAJPk9VqGemrCJV1Zqs
✅ Preview: https://tutorbook-git-request-tutorbook.vercel.app

@nicholaschiang nicholaschiang marked this pull request as draft October 27, 2021 03:23
@nicholaschiang
Copy link
Copy Markdown
Member Author

nicholaschiang commented Oct 27, 2021 •
edited
Loading

📝 Changed routes:

/[org]/request
Screenshot of /[org]/request
(view full size)

And 1 other route:

Commit c0e3139 (https://tutorbook-cbhby8ihc-tutorbook.vercel.app).

@nicholaschiang nicholaschiang force-pushed the request branch 2 times, most recently from b9d4e6e to 0e0b48f Compare October 27, 2021 03:39
@nicholaschiang nicholaschiang marked this pull request as ready for review October 27, 2021 03:39
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2021 •
edited
Loading

Codecov Report

Merging #266 (c0e3139) into develop (3ece2f5) will decrease coverage by 4.12%.
The diff coverage is 89.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #266      +/-   ##
===========================================
- Coverage    69.39%   65.27%   -4.13%     
===========================================
  Files          218      220       +2     
  Lines         4578     4625      +47     
  Branches      1246     1256      +10     
===========================================
- Hits          3177     3019     -158     
- Misses        1401     1606     +205
Impacted Files Coverage Δ
pages/[org]/request.tsx 85.71% <85.71%> (ø)
components/request.tsx 90.90% <90.90%> (ø)
lib/api/get/people.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/api/get/last-time.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/api/get/meeting-venue.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/mail/meetings/create.tsx 0.00% <0.00%> (-100.00%) ⬇️
lib/api/update/people-tags.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/api/update/meeting-tags.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/api/verify/time-in-availability.ts 0.00% <0.00%> (-100.00%) ⬇️
lib/api/routes/meetings/create.tsx 0.00% <0.00%> (-95.46%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ece2f5...c0e3139. Read the comment docs.

@cypress
Copy link
Copy Markdown

cypress bot commented Oct 27, 2021 •
edited
Loading


Test summary

30 • 4 • 0 • 0 • Flakiness 2

Run details
Project tutorbook
Status Failed
Commit c0e3139
Started Oct 28, 2021 6:06 PM
Ended Oct 28, 2021 6:25 PM
Duration 19:04 💡
OS Linux Ubuntu - 20.04
Browser Chrome 94

View run in Cypress Dashboard ➡️

Failures

org/users/id/index.spec.ts 3 Failed
1 User display page > collects profiles before booking meetings
2 User display page > lets parents book meetings for their kids
3 User display page > signs users up before booking meetings
profile.spec.ts 1 Failed
1 Profile page > updates volunteer profiles

Flakiness

signup.spec.ts 1 Flakiness
1 Signup page > signs new volunteers up
settings/index.spec.ts 1 Flakiness
1 Org settings page > displays and updates org settings

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@nicholaschiang nicholaschiang merged commit 5c0dbf1 into develop Oct 28, 2021
@nicholaschiang nicholaschiang deleted the request branch October 28, 2021 18:34
nicholaschiang added a commit that referenced this pull request Oct 28, 2021
@nicholaschiang
feat: add tutor request form (#266)
5a5c75a 
* wip(request): create front-end page and form

* wip: add request creation email back-end

* fix(components/request): login with Google

* fix(api/requests): send `201` status res

* fix(mail/request): remove availability from query

* wip(mail/request): include topic in subject line

* wip(components/request): remove reference field

* wip(mail/request): reword email content

* wip(mail/request): add `TODO` comment about `AND` filters

* test(org/request): test new student request form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicholaschiang