fix(cli): Make sure parse errors don't have color escapes on non-TTYs#210
Merged
andreubotella merged 1 commit intotrynova:mainfrom Jun 5, 2024
Merged
Conversation
aapoalas
approved these changes
Jun 5, 2024
andreubotella
added a commit
to andreubotella/eshost
that referenced
this pull request
Jun 5, 2024
This works with trynova/nova#210, not on previous versions.
CanadaHonk
pushed a commit
to test262-fyi/eshost
that referenced
this pull request
Jun 9, 2024
This works with trynova/nova#210, not on previous versions.
andreubotella
added a commit
to andreubotella/nova
that referenced
this pull request
Jul 19, 2024
PR trynova#210 added this workaround for oxc-project/oxc#3539, and it can now be removed.
andreubotella
added a commit
that referenced
this pull request
Jul 19, 2024
#325) PR #210 added this workaround for oxc-project/oxc#3539, and it can now be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes oxc-project/oxc#3539.