Skip to content

chore: Configure profile on PR hotpath CI#168

Merged
load1n9 merged 2 commits intotryandromeda:mainfrom
pawurb:hotpath_pr2
Oct 19, 2025
Merged

chore: Configure profile on PR hotpath CI#168
load1n9 merged 2 commits intotryandromeda:mainfrom
pawurb:hotpath_pr2

Conversation

@pawurb
Copy link
Contributor

@pawurb pawurb commented Oct 19, 2025

As a follow up to #167 . This PR enables hotpath CI integration, to post benchmark comment on each PR. I suppose that examples/performance.ts script could be replaced with something better covering potential bottlenecks, but it's not something I can propose not knowing the lib well.

@pawurb
Copy link
Contributor Author

pawurb commented Oct 19, 2025

There's a CI permissions issue, I'll try to resolve it.

@pawurb pawurb marked this pull request as draft October 19, 2025 15:54
@pawurb pawurb marked this pull request as ready for review October 19, 2025 16:30
@pawurb
Copy link
Contributor Author

pawurb commented Oct 19, 2025

I've double checked this config with a fork of my fork. By splitting profile-on-pr into profile and comment steps, we can make it work. profile executes arbitrary code, but has only read access so it's safe. And comment has write access, but does not execute any code coming from the PR, only uses hotpath CLI to post metrics.

Once merged, all the subsequent PRs should get a benchmarking comment.

@load1n9 load1n9 self-requested a review October 19, 2025 17:11
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM!

@load1n9 load1n9 merged commit ce6a191 into tryandromeda:main Oct 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants