chore: Update hotpath, use measure_all macro#167
Merged
load1n9 merged 2 commits intotryandromeda:mainfrom Oct 19, 2025
Merged
Conversation
Member
|
I see you fixed it already, nice |
marc2332
approved these changes
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This PR updates https://github.com/pawurb/hotpath to
0.5. Notable change is introduction ofmeasure_allmacro that allows to automatically profile all methods inside animpl(ormod) reducing config overhead.Once this is merged we could also enable automatic profiling on each PR. An example is here: pawurb#2. It sends a comment with perf changes to every PR, to help spot regressions. A sample ts script could probably be improved to cover more edge cases.
For now I've only enabled timing perf. You're using recursive functions so output of memory profiling does not make much sense now. I'll try to improve it in the future release.