Skip to content

Add server-decorator#2

Merged
trustin merged 2 commits intotrustin:new_sitefrom
ikhoon:new_site_1st
Apr 8, 2020
Merged

Add server-decorator#2
trustin merged 2 commits intotrustin:new_sitefrom
ikhoon:new_site_1st

Conversation

@ikhoon
Copy link
Copy Markdown

@ikhoon ikhoon commented Apr 8, 2020

No description provided.

@ikhoon ikhoon requested a review from trustin as a code owner April 8, 2020 06:02
## See also

- [Decorating a client](/docs/client-decorator)
- [`RequestContext` custom attributes](docs/advanced-custom-attributes)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/docs/advanced ...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops..

@trustin trustin merged commit 55c45ed into trustin:new_site Apr 8, 2020
@ikhoon ikhoon deleted the new_site_1st branch April 21, 2020 02:52
trustin added a commit that referenced this pull request May 19, 2023
# This is the 1st commit message:

Add server-side Unix domain socket support

Motivation:

In service mesh environment, it's quite common for a sidecar to
communicate with an app using a Unix domain socket. Armeria could be
used in such a scenarios if it is capable of serving requests on a Unix
domain socket.

Modifications:

- Added `DomainSocketAddress`
- Added `ServerPort.isDomainSocket()`
- Added various getters to `TransportType` and `TransportTypeProvider`
  so it provides the transport-specific information about domain socket
  classes and whether the transport supports domain sockets
- Added `ChannelUtil.localAddress()` and `remoteAddress()` and replace
  the direct invocation of `Channel.localAddress()` and
  `remoteAddress()` to work around the issue where Netty's domain socket
  channel returns `null`
  - See: netty/netty#13323
- Added `ChannelUtil.isTcpOption()` to determine whether the given
  `ChannelOption` is for TCP or not, so that a user doesn't get a WARN
  log when they use domain sockets
- Made `ServerRule` and `ServerExtension`not instantiate their default
  `WebClient`s lazily, so that a user can start a serer that listens
  only on a domain socket

Result:

- Armeria is now capable of serving requests from a Unix domain socket,
  making it more service-mesh-friendly.

# This is the commit message #2:

Fix leaks

# This is the commit message #3:

Update Netty to 4.1.92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants