Merged
Conversation
trustin
reviewed
Apr 8, 2020
| ## See also | ||
|
|
||
| - [Decorating a client](/docs/client-decorator) | ||
| - [`RequestContext` custom attributes](docs/advanced-custom-attributes) |
trustin
added a commit
that referenced
this pull request
May 19, 2023
# This is the 1st commit message: Add server-side Unix domain socket support Motivation: In service mesh environment, it's quite common for a sidecar to communicate with an app using a Unix domain socket. Armeria could be used in such a scenarios if it is capable of serving requests on a Unix domain socket. Modifications: - Added `DomainSocketAddress` - Added `ServerPort.isDomainSocket()` - Added various getters to `TransportType` and `TransportTypeProvider` so it provides the transport-specific information about domain socket classes and whether the transport supports domain sockets - Added `ChannelUtil.localAddress()` and `remoteAddress()` and replace the direct invocation of `Channel.localAddress()` and `remoteAddress()` to work around the issue where Netty's domain socket channel returns `null` - See: netty/netty#13323 - Added `ChannelUtil.isTcpOption()` to determine whether the given `ChannelOption` is for TCP or not, so that a user doesn't get a WARN log when they use domain sockets - Made `ServerRule` and `ServerExtension`not instantiate their default `WebClient`s lazily, so that a user can start a serer that listens only on a domain socket Result: - Armeria is now capable of serving requests from a Unix domain socket, making it more service-mesh-friendly. # This is the commit message #2: Fix leaks # This is the commit message #3: Update Netty to 4.1.92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.