Skip to content

bugfix: fix the typos in trpc-jave-demo's yaml #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wardseptember merged 1 commit into from
Jun 12, 2025
Merged

bugfix: fix the typos in trpc-jave-demo's yaml #82

wardseptember merged 1 commit into from
Jun 12, 2025

Conversation

@gbccccc
Copy link
Contributor

@gbccccc gbccccc commented May 17, 2025 •
edited
Loading

When trying to run the ClientTest of trpc-java-demo, I got the following error

java.lang.IllegalStateException: Yaml config parse exception, position(client->service), interface name is com.tencent.trpc.demo.proto.GreeterserviceAPI
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.loadClass(BackendConfigParser.java:86) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.lambda$parseConfig$0(BackendConfigParser.java:70) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]     
        at java.util.Optional.map(Optional.java:260) ~[?:?]
        at com.tencent.trpc.core.utils.BinderUtils.bind(BinderUtils.java:160) ~[trpc-core-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.core.utils.BinderUtils.bind(BinderUtils.java:144) ~[trpc-core-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.parseConfig(BackendConfigParser.java:69) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
        at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
        at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
        at com.tencent.trpc.container.config.yaml.BackendConfigParser.parseConfigMap(BackendConfigParser.java:47) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.yaml.ClientConfigParser.parseClientConfig(ClientConfigParser.java:42) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.ApplicationConfigParser.doParse(ApplicationConfigParser.java:86) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.config.ApplicationConfigParser.parse(ApplicationConfigParser.java:41) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.container.container.DefaultContainer.start(DefaultContainer.java:37) ~[trpc-container-default-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.server.container.TRPC.start(TRPC.java:32) [trpc-server-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.server.main.Main.main(Main.java:36) [trpc-server-1.4.0-SNAPSHOT.jar:?]
        at com.tencent.trpc.demo.example.yaml.ClientTest.main(ClientTest.java:32) [classes/:?]
        at org.codehaus.mojo.exec.ExecJavaMojo$1.run(ExecJavaMojo.java:279) [exec-maven-plugin-3.1.0.jar:?]
        at java.lang.Thread.run(Thread.java:842) [?:?]

After checking, I found some typos for interface names in trpc_java_client.yaml. The interface names don't match those defined in the demo.proto

@github-actions
Copy link

github-actions bot commented May 17, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@codecov
Copy link

codecov bot commented May 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13154%. Comparing base (33f8bfb) to head (6f7b00a).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##                master         #82         +/-   ##
=====================================================
- Coverage     70.23677%   70.13154%   -0.10524%     
+ Complexity        4253        4240         -13     
=====================================================
  Files              437         437                 
  Lines            17105       17105                 
  Branches          1727        1727                 
=====================================================
- Hits             12014       11996         -18     
- Misses            3984        3993          +9     
- Partials          1107        1116          +9

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gbccccc
Copy link
Contributor Author

gbccccc commented May 17, 2025

I have read the CLA Document and I hereby sign the CLA

@wardseptember
Copy link
Collaborator

wardseptember commented Jun 12, 2025

合入了，感谢贡献

@wardseptember wardseptember merged commit 1674370 into trpc-group:master Jun 12, 2025
3 of 4 checks passed
liuzengh added a commit to liuzengh/cla-database that referenced this pull request Jul 21, 2025
@liuzengh
@gbccccc has signed the CLA in trpc-group/trpc-java#82
8639dd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gbccccc @wardseptember