-
Notifications
You must be signed in to change notification settings - Fork 43
fix TcpDecoder memory leak #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=====================================================
+ Coverage 69.27388% 69.34263% +0.06874%
- Complexity 4108 4111 +3
=====================================================
Files 428 428
Lines 16774 16779 +5
Branches 1698 1700 +2
=====================================================
+ Hits 11620 11635 +15
+ Misses 4048 4039 -9
+ Partials 1106 1105 -1
|
|
@wardseptember PTAL |
|
I have read the CLA Document and I hereby sign the CLA |
...pc-transport-netty/src/test/java/com/tencent/trpc/transport/netty/NettyCodecAdapterTest.java
Show resolved
Hide resolved
...t/trpc-transport-netty/src/main/java/com/tencent/trpc/transport/netty/NettyCodecAdapter.java
Show resolved
Hide resolved
|
感谢贡献,我们评估一下 |
...t/trpc-transport-netty/src/main/java/com/tencent/trpc/transport/netty/NettyCodecAdapter.java
Show resolved
Hide resolved
...pc-transport-netty/src/test/java/com/tencent/trpc/transport/netty/NettyCodecAdapterTest.java
Show resolved
Hide resolved
...t/trpc-transport-netty/src/main/java/com/tencent/trpc/transport/netty/NettyCodecAdapter.java
Outdated
Show resolved
Hide resolved
你需要用github账户提交push分支,然后才能授权成功 |
|
感谢贡献,已合入 |
reproduce code
when TcpDecoder#decode() throw exception . ByteBuf param not released
expect refcnt 0 , actual 1
Solution
when decode excpetion . skip all readable bytes let
ByteToMessageDecoderrelease ByteBuf