Skip to content

For 5.0.0: Remove all deprecated items#411

Merged
trishume merged 2 commits into
trishume:masterfrom
Enselic:remove-all-deprecated-items
Jan 17, 2022
Merged

For 5.0.0: Remove all deprecated items#411
trishume merged 2 commits into
trishume:masterfrom
Enselic:remove-all-deprecated-items

Conversation

@Enselic

@Enselic Enselic commented Jan 3, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

Enselic added a commit to Enselic/syntect that referenced this pull request Jan 3, 2022

@trishume trishume left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like removing the theme attributes, I think nobody uses those and they affect the binary format and clutter the docs.

I'd rather keep the deprecated html functions in case it's been a while since someone worked on a syntect project, it's just much friendlier. I really wish there was something like a deprecation attribute except it produced a build error instead of a warning.

One other option to keeping them is to keep them deprecated, but create a new empty enum type named Deprecated or something, and change those functions to take Deprecated as an argument, delete their bodies, and maybe also add `#[doc(hidden)]. Then check that when they're called they produce both a type error and a deprecation warning.

@Enselic

Enselic commented Jan 16, 2022

Copy link
Copy Markdown
Collaborator Author

If you want to keep them, we'll keep them :) I restored the original code in src/html.rs now.

@Enselic Enselic requested a review from trishume January 16, 2022 20:15
@trishume trishume merged commit ba81cfb into trishume:master Jan 17, 2022
@Enselic Enselic deleted the remove-all-deprecated-items branch January 17, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants