Skip to content

feat: added defineJob method in TriggerClient#176

Merged
ericallam merged 3 commits intotriggerdotdev:mainfrom
akhill10:feat/client-define-job
Jul 17, 2023
Merged

feat: added defineJob method in TriggerClient#176
ericallam merged 3 commits intotriggerdotdev:mainfrom
akhill10:feat/client-define-job

Conversation

@akhill10
Copy link
Copy Markdown
Contributor

@akhill10 akhill10 commented Jul 15, 2023 •
edited
Loading

Fixes #162

  • Added a defineJob method in the TriggerClient
  • Replaced new Job(client, options) with client.defineJob(options) in examples.

/claim #162

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 15, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1961b99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@trigger.dev/sdk Patch
nextjs-12 Patch
@examples/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@algora-pbc algora-pbc bot mentioned this pull request Jul 15, 2023
Closed
ericallam
ericallam requested changes Jul 15, 2023
View reviewed changes
packages/trigger-sdk/src/triggerClient.ts Outdated
};
}

defineJob(
Copy link
Copy Markdown
Member

@ericallam ericallam Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but I think defineJob needs to be generic so the type of the job returned includes the actual Trigger type (we're eventually going to support direct job invocation, so need to make sure the Trigger type is preserved and not just any) Otherwise this whole PR is 👍

Copy link
Copy Markdown
Contributor Author

@akhill10 akhill10 Jul 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agree. Done

@ericallam
Copy link
Copy Markdown
Member

ericallam commented Jul 15, 2023

Can you add a changeset for a "patch" update to the @trigger.dev/sdk package and include it in this PR?

To add a change, run this from the root of the repo:

pnpm run changeset:add

Then select @trigger.dev/sdk only and follow the steps for creating a "patch" changeset

@akhill10 akhill10 force-pushed the feat/client-define-job branch from c11e881 to 1961b99 Compare July 16, 2023 05:19
@ericallam ericallam merged commit 5336317 into triggerdotdev:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericallam ericallam ericallam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TRI-606] Add a TriggerClient#defineJob function that can be used instead of the Job constructor

2 participants

@akhill10 @ericallam