Fix wasm loading of languages w/ multiple reserved word sets#5475
Fix wasm loading of languages w/ multiple reserved word sets#5475maxbrunsfeld merged 1 commit intomasterfrom
Conversation
(cherry picked from commit d3ff0ce)
|
Successfully created backport PR for |
(cherry picked from commit d3ff0ce)
|
@WillLillis @amaanq Thanks for the review and backport. Are you cool with doing a patch release on the 0.26 line, so I can get this crash fix into Zed? I can do it, just wanted to check in since I typically cause chaos when I do releases these days 😓 . |
|
The workflow is documented now (for no particular reason 😇 ) but I can do it if you prefer. Is it urgent or can it wait till the end of the week? (There's one or two backportable PRs that would be nice to include, but nothing that needs to hold up a release.) |
|
That would be wonderful @clason , and thanks for the docs pointer. Sooner would be better, since this crash is reachable for end users depending on what grammars they install. |
|
@maxbrunsfeld I don't have any issue with a patch release. If it's not super urgent like @clason said, I can take a look at those other PRs later tonight after work to get them in. If you need it sooner, that's fine too :) |
|
Tonight would be totally fine |
|
Too late, it's already on crates.io! |
|
Just got the emails. Thank you! |
#52856) This PR bumps Tree-sitter for this crash fix tree-sitter/tree-sitter#5475 Release Notes: - Fixed a crash that could occasionally occur when parsing files using certain language extensions
Previously, languages with multiple reserved word sets were not handled properly when loaded from WASM. This would cause crashes during lexing.