Reorganize rust crates into a flat crates directory, simplify some CI steps#4496
Merged
maxbrunsfeld merged 8 commits intomasterfrom Jun 6, 2025
Merged
Reorganize rust crates into a flat crates directory, simplify some CI steps#4496maxbrunsfeld merged 8 commits intomasterfrom
crates directory, simplify some CI steps#4496maxbrunsfeld merged 8 commits intomasterfrom
Conversation
crates directorycrates directory, simplify some CI steps
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure.
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows).
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows) and raise the limit for the generate step to 3 (reduces the chance of timeouts).
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows) and raise the limit for the generate step to 3 (reduces the chance of timeouts).
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows) and raise the limit for the generate step to 3 (reduces the chance of timeouts). Also raise the timeout limit to 30 minutes (it's more expensive to have to restart flaky tests than to let them run).
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows). Also raise the timeout limit to 30 minutes (it's more expensive to have to restart flaky tests than to let them run).
clason
added a commit
that referenced
this pull request
Jun 27, 2025
Problem: After #4496, the crater tests from nvim-treesitter no longer run on PRs with relevant changes. Solution: Update the paths in the workflows to the new structure. Also throttle the build step to 10 parallel tasks (reduces flakiness on Windows). Also raise the timeout limit to 30 minutes (it's more expensive to have to restart flaky tests than to let them run).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the project less confusing to navigate by reorganizing the file structure. The core library is still in the top-level
libfolder, because it also contains the C source code, but all of the CLI-related crates are now flattened under a top-levelcratesfolder, like many other multi-crate Rust repos.Also, I've removed some CI steps that are adding friction to my own contributions. We no longer install rust nightly in addition to Rust stable for
clippyandfmt. I don't want formatting failures in CI that will not match what I do normally during local development. Cargo fmt happens when I save files, but only on one Rust toolchain, not multiple. Wherever possible, I want our formatting checks to just enforce the normal rust defaults, nothing custom or extra-pedantic.