fix(make): make install shouldn’t fail when a parser bundles no queries#4284
fix(make): make install shouldn’t fail when a parser bundles no queries#4284clason merged 1 commit intotree-sitter:masterfrom
make install shouldn’t fail when a parser bundles no queries#4284Conversation
|
Arguably, a parser should bundle queries, so this should fail... |
eh, is there a standard for the queries yet? I know that some editors adopt neovim’s query convention but is there anything from tree-sitter itself? |
|
The thing that is (not) standardized are capture names, but those are purely cosmetic and easy to adapt. The important thing is to have queries that 1. can be adapted instead of everyone having to write from scratch and 2. more importantly, can be tested in CI to make sure breaking grammar changes don't slip through without being marked as such (and demonstrated how to adapt to). |
makes sense, I still steal the queries from neovim then. |
|
Doesn't mean we shouldn't fix this, too. |
|
Successfully created backport PR for |
Relates to uyha/tree-sitter-cmake#34 (comment)