Skip to content

fix(make): make install shouldn’t fail when a parser bundles no queries#4284

Merged
clason merged 1 commit intotree-sitter:masterfrom
mavit:make-no-queries
Mar 14, 2025
Merged

fix(make): make install shouldn’t fail when a parser bundles no queries#4284
clason merged 1 commit intotree-sitter:masterfrom
mavit:make-no-queries

Conversation

@mavit
Copy link
Contributor

@mavit mavit commented Mar 12, 2025

@clason
Copy link
Contributor

clason commented Mar 12, 2025

Arguably, a parser should bundle queries, so this should fail...

@uyha
Copy link

uyha commented Mar 12, 2025

Arguably, a parser should bundle queries, so this should fail...

eh, is there a standard for the queries yet? I know that some editors adopt neovim’s query convention but is there anything from tree-sitter itself?

@clason
Copy link
Contributor

clason commented Mar 12, 2025

The thing that is (not) standardized are capture names, but those are purely cosmetic and easy to adapt. The important thing is to have queries that 1. can be adapted instead of everyone having to write from scratch and 2. more importantly, can be tested in CI to make sure breaking grammar changes don't slip through without being marked as such (and demonstrated how to adapt to).

@uyha
Copy link

uyha commented Mar 12, 2025

The thing that is (not) standardized are capture names, but those are purely cosmetic and easy to adapt. The important thing is to have queries that 1. can be adapted instead of everyone having to write from scratch and 2. more importantly, can be tested in CI to make sure breaking grammar changes don't slip through without being marked as such (and demonstrated how to adapt to).

makes sense, I still steal the queries from neovim then.

@mavit mavit closed this Mar 13, 2025
@clason clason reopened this Mar 13, 2025
@clason clason added the ci:backport release-0.25 Backport label label Mar 13, 2025
@clason
Copy link
Contributor

clason commented Mar 13, 2025

Doesn't mean we shouldn't fix this, too.

@clason clason merged commit 17471bd into tree-sitter:master Mar 14, 2025
39 of 40 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
@tree-sitter-ci-bot
Copy link

Successfully created backport PR for release-0.25:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants