Fix cases where error recovery could infinite loop#4257
Merged
maxbrunsfeld merged 7 commits intomasterfrom Mar 4, 2025
Merged
Conversation
We found this problem when debugging an infinite loop that happened during error recovery when using the Zig grammar. The large number of unnecessary paused stack versions were preventing the correct recovery strategy from being tried.
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Rename corpus test functions to allow easy filtering by language * Use usize for seed argument * Avoid retaining useless stack versions when reductions merge We found this problem when debugging an infinite loop that happened during error recovery when using the Zig grammar. The large number of unnecessary paused stack versions were preventing the correct recovery strategy from being tried. * Fix leaked lookahead token when reduction results in a merged stack * Enable running PHP tests in CI * Fix possible infinite loop during error recovery at EOF * Account for external scanner state changes when detecting changed ranges in subtrees (cherry picked from commit 066fd77)
maxbrunsfeld
added a commit
that referenced
this pull request
Mar 4, 2025
* Rename corpus test functions to allow easy filtering by language * Use usize for seed argument * Avoid retaining useless stack versions when reductions merge We found this problem when debugging an infinite loop that happened during error recovery when using the Zig grammar. The large number of unnecessary paused stack versions were preventing the correct recovery strategy from being tried. * Fix leaked lookahead token when reduction results in a merged stack * Enable running PHP tests in CI * Fix possible infinite loop during error recovery at EOF * Account for external scanner state changes when detecting changed ranges in subtrees (cherry picked from commit 066fd77) Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
maxbrunsfeld
added a commit
to zed-industries/zed
that referenced
this pull request
Mar 5, 2025
maxbrunsfeld
added a commit
to zed-industries/zed
that referenced
this pull request
Mar 5, 2025
For tree-sitter/tree-sitter#4257 Release Notes: - Fixed a hang that could occur when editing certain Zig files.
maxbrunsfeld
added a commit
to zed-industries/zed
that referenced
this pull request
Mar 5, 2025
For tree-sitter/tree-sitter#4257 Release Notes: - Fixed a hang that could occur when editing certain Zig files.
rtfeldman
pushed a commit
to zed-industries/zed
that referenced
this pull request
Mar 6, 2025
For tree-sitter/tree-sitter#4257 Release Notes: - Fixed a hang that could occur when editing certain Zig files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.