Skip to content

fix symbol leak for character sets#4255

Merged
clason merged 1 commit intotree-sitter:masterfrom
polazarus:patch-1
Mar 4, 2025
Merged

fix symbol leak for character sets#4255
clason merged 1 commit intotree-sitter:masterfrom
polazarus:patch-1

Conversation

@polazarus
Copy link
Contributor

@polazarus polazarus commented Mar 3, 2025

fix #4209

maxbrunsfeld
maxbrunsfeld approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@maxbrunsfeld maxbrunsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Mar 3, 2025

Looks like we need to run cargo fmt

@clason clason added the ci:backport release-0.25 Backport label label Mar 4, 2025
@clason clason merged commit 8138dba into tree-sitter:master Mar 4, 2025
20 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
@polazarus @github-actions
fix(generate): mark TSCharacterRange as static (#4255)
9557262 
Problem: Linking different parsers into one executable fails due to duplicate symbols.

Solution: Mark `TSCharacterRange` as `static` when generating parsers.

fixes #4209

(cherry picked from commit 8138dba)
@tree-sitter-ci-bot
Copy link

tree-sitter-ci-bot bot commented Mar 4, 2025

Successfully created backport PR for release-0.25:

@tree-sitter-ci-bot tree-sitter-ci-bot bot mentioned this pull request Mar 4, 2025
Merged
clason pushed a commit that referenced this pull request Mar 4, 2025
@polazarus @clason
fix(generate): mark TSCharacterRange as static (#4255)
b1a7074 
Problem: Linking different parsers into one executable fails due to duplicate symbols.

Solution: Mark `TSCharacterRange` as `static` when generating parsers.

fixes #4209

(cherry picked from commit 8138dba)
@clason clason mentioned this pull request Jul 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbrunsfeld maxbrunsfeld maxbrunsfeld approved these changes

Assignees

No one assigned

Labels

ci:backport release-0.25 Backport label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to link multiple grammars with same rule since 0.25.1

3 participants

@polazarus @maxbrunsfeld @clason