Skip to content

Use C++14 to allow building for Electron 11 on MacOS#83

Closed
sergei-dyshel wants to merge 1 commit intotree-sitter:masterfrom
sergei-dyshel:electron-11
Closed

Use C++14 to allow building for Electron 11 on MacOS#83
sergei-dyshel wants to merge 1 commit intotree-sitter:masterfrom
sergei-dyshel:electron-11

Conversation

@sergei-dyshel
Copy link

@sergei-dyshel sergei-dyshel commented Mar 9, 2021

Fixes #82.

@gpetrov gpetrov mentioned this pull request May 30, 2021
Closed
@Symbolk
Copy link

Symbolk commented May 30, 2021

@maxbrunsfeld Could this be merged and released? A timely change for me.

@jinu-jang
Copy link

jinu-jang commented Jun 1, 2021

This is just necessary for recent electron versions (v11, v12)
@sergei-dyshel thanks for the fix. This at least got me unblocked for now

@Symbolk
Copy link

Symbolk commented Jun 2, 2021

Right, for those who use electron v11+, here is the manual instruction to rebuild this module:

https://github.com/Symbolk/somanyconflicts#known-issues

@DeeDeeG
Copy link

DeeDeeG commented Jul 4, 2021

👍, and I think not merging this might slow progress on using Electron 11 in the Atom text editor. Might have to fork this package for Atom just to get it building in Electron 11.

@DeeDeeG DeeDeeG mentioned this pull request Jul 4, 2021
Merged
64 tasks
@sadick254
Copy link

sadick254 commented Jul 6, 2021

@maxbrunsfeld What could be holding back this PR from getting merged? As @DeeDeeG has stated this currently blocks Atom from upgrading to electron version 11.4.7.

sadick254 added a commit to atom/atom that referenced this pull request Jul 8, 2021
@sadick254
Use tree-sitter fork while waiting for tree-sitter/node-tree-sitter#83
290bd57 
to get merged
aminya
aminya suggested changes Jul 13, 2021
View reviewed changes
Copy link

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not c++17?

binding.gyp
],
'xcode_settings': {
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14',
Copy link

@aminya aminya Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'CLANG_CXX_LANGUAGE_STANDARD': 'c++14',
'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',

aminya
aminya reviewed Jul 13, 2021
View reviewed changes
binding.gyp
@@ -31,7 +31,7 @@
"-std=c++0x",
Copy link

@aminya aminya Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"-std=c++0x",
"-std=c++17",

@jinu-jang jinu-jang mentioned this pull request Jul 20, 2021
Closed
@Symbolk
Copy link

Symbolk commented Sep 2, 2021

After being torture by native module (node-gyp and electron-rebuild) for months, I finally switched to wasm of treesitter, and it seems working fine: https://github.com/Symbolk/somanyconflicts

Maybe this solution helps some of you.

@tim-lai tim-lai mentioned this pull request Sep 22, 2021
Closed
@verhovsky
Copy link
Collaborator

verhovsky commented Sep 30, 2021

This PR can be closed because #92 (merged) did the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aminya aminya aminya requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build for Electron 11 on MacOS fails

7 participants

@sergei-dyshel @Symbolk @jinu-jang @DeeDeeG @sadick254 @verhovsky @aminya