Merged
Conversation
|
|
bb12589 to
6128124
Compare
4 tasks
nirga
reviewed
Jan 29, 2024
packages/instrumentation-langchain/test/instrumentation.test.ts
Outdated
Show resolved
Hide resolved
| assert.ok(spanNames.includes("langchain.agent")); | ||
| }).timeout(60000); | ||
|
|
||
| it("should set attributes in span for chain instrumentation", async () => { |
Contributor
Author
There was a problem hiding this comment.
Followed this doc to add LCEL test. Let me know if I should cover anything else as well.
|
|
||
| it("should set attributes in span for tools and agent instrumentation", async () => { | ||
| const llm = new ChatOpenAI({}); | ||
| const tools = [new Calculator(), new langchainToolsModule.SerpAPI()]; |
Member
There was a problem hiding this comment.
Can we remove the dependency on the SerpAPI?
Contributor
Author
There was a problem hiding this comment.
Added test which use WikipediaQueryRun instead of SerpAPI.
6128124 to
758f458
Compare
758f458 to
8caafc1
Compare
…ibutes in test cases, add test for LCEL
8caafc1 to
51e4be8
Compare
411aff5 to
a84c60a
Compare
nirga
approved these changes
Feb 4, 2024
5war00p
pushed a commit
to 5war00p/openllmetry-js
that referenced
this pull request
Feb 4, 2024
Co-authored-by: Nir Gazit <nir.gzt@gmail.com> Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>
5war00p
pushed a commit
to 5war00p/openllmetry-js
that referenced
this pull request
Feb 4, 2024
Co-authored-by: Nir Gazit <nir.gzt@gmail.com> Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>
5war00p
pushed a commit
to 5war00p/openllmetry-js
that referenced
this pull request
Feb 4, 2024
Co-authored-by: Nir Gazit <nir.gzt@gmail.com> Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
/claim #7