Skip to content

Conversation

@galkleinman
Copy link
Contributor

No description provided.

@galkleinman galkleinman merged commit 39976b6 into main Sep 5, 2023
mpozniak95 pushed a commit to mpozniak95/openllmetry that referenced this pull request May 24, 2024
nina-kollman pushed a commit that referenced this pull request Aug 11, 2025
nirga added a commit that referenced this pull request Aug 24, 2025
…vements

1. Fix trace_id/span_id type conversion across all instrumentations
   - Convert OpenTelemetry integer IDs to strings before upload calls
   - Standardize all signatures to use 4-parameter format consistently
   - Fix OpenAI config signature mismatch (was expecting 3 params, using 4)

2. Improve code readability (Issue #4 from PR review)
   - Extract helper methods to reduce complex nested if/else blocks
   - Use descriptive variable names (arg_index, content_item vs i, arg)
   - Apply consistent patterns across VertexAI and Google GenAI instrumentations
   - Maintain both async and sync versions with shared logic

3. Fix VertexAI ChatSession model name extraction
   - Add support for getting model name from ChatSession._model reference
   - Ensures send_message spans show correct model instead of "unknown"

All changes maintain backward compatibility and pass linting checks.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants