Add more semantic conventions to query embeddings / query result events#362
Merged
nirga merged 5 commits intotraceloop:mainfrom Jan 25, 2024
paolorechia:feature/semantic-convention-query-events
Merged
Add more semantic conventions to query embeddings / query result events#362nirga merged 5 commits intotraceloop:mainfrom paolorechia:feature/semantic-convention-query-events
nirga merged 5 commits intotraceloop:mainfrom
paolorechia:feature/semantic-convention-query-events
Conversation
nirga
reviewed
Jan 25, 2024
packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv/ai/__init__.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nirga is this what you mean? I merged all of them into a single |
Contributor
Author
|
OK, also standardized it a bit more. |
nirga
reviewed
Jan 25, 2024
| class EventName(Enum): | ||
| class EventAttributes(Enum): | ||
| # Query Embeddings | ||
| VECTOR_DB_QUERY_EMBEDDINGS = "vector_db.query.embeddings" |
Member
There was a problem hiding this comment.
What's the difference between VECTOR_DB_QUERY_EMBEDDINGS and VECTOR_DB_QUERY_EMBEDDINGS_VECTOR?
Contributor
Author
|
The first is the event name and the second is the attribute vector (where
the embeddings vector is stored)
Nir Gazit ***@***.***> schrieb am Do. 25. Jan. 2024 um 16:49:
… ***@***.**** commented on this pull request.
------------------------------
In
packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv/ai/__init__.py
<#362 (comment)>
:
> @@ -44,8 +44,17 @@ class SpanAttributes:
LLM_REPETITION_PENALTY = "llm.watsonx.repetition_penalty"
-class EventName(Enum):
+class EventAttributes(Enum):
+ # Query Embeddings
VECTOR_DB_QUERY_EMBEDDINGS = "vector_db.query.embeddings"
What's the difference between VECTOR_DB_QUERY_EMBEDDINGS and
VECTOR_DB_QUERY_EMBEDDINGS_VECTOR
—
Reply to this email directly, view it on GitHub
<#362 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJDFZYS3G7IW57BGSMWSO3YQJ5JLAVCNFSM6AAAAABCJMY2FCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBUGA3DIMRYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
@paolorechia ahh got it! So let's put the event name in a separate |
Contributor
Author
|
Sounds good.
Nir Gazit ***@***.***> schrieb am Do. 25. Jan. 2024 um 17:08:
… @paolorechia <https://github.com/paolorechia> ahh got it! So let's put
the event name in a separate enum and then have an enum for all event
attributes, WDYT?
—
Reply to this email directly, view it on GitHub
<#362 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJDFZYNM4TWUJ3NIQ4E3T3YQJ7PZAVCNFSM6AAAAABCJMY2FCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQGUYTSNBYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@nirga There we go :) |
nirga
approved these changes
Jan 25, 2024
nina-kollman
pushed a commit
that referenced
this pull request
Aug 11, 2025
…ts (#362) Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.