feat: google-vertexai-instrumentation by 5war00p · Pull Request #289 · traceloop/openllmetry

5war00p · 2023-12-25T09:21:55Z

closes #249
/claim #249

5war00p · 2023-12-25T09:44:59Z

@nirga Gemini Trace:

nirga

Thanks so much for this! In addition to the comments, you don't seem to instrument the chat API. Also, please make sure to test actual span attributes and not just the existence of spans.

.github/workflows/ci.yml

...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py

packages/traceloop-sdk/tests/test_vertexai_instrumentation.py

packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py

packages/sample-app/sample_app/vertexai_functions.py

...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py

5war00p · 2024-01-02T09:16:13Z

@nirga Couldn't get model_name in the response and unable to find a way to correlate between model initialisation and the predict function call. Apart from the model_name other issues were resolved and pushed.

nirga · 2024-01-04T11:23:29Z

packages/traceloop-sdk/pyproject.toml

When trying to run poetry install I'm getting -

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.

nirga · 2024-01-04T11:24:51Z

packages/sample-app/pyproject.toml

When trying to run poetry install I'm getting -

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.

Its taking so longer when i try to add google-cloud-aiplatform using poetry.

nirga · 2024-01-04T11:25:09Z

packages/opentelemetry-instrumentation-vertexai/pyproject.toml

Missing lock file

...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py

5war00p · 2024-01-04T16:05:23Z

@nirga pushed the model_name solution

packages/opentelemetry-instrumentation-vertexai/pyproject.toml

packages/traceloop-sdk/tests/test_vertexai_instrumentation.py

…m poetry

Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>

5war00p added 2 commits December 25, 2023 14:47

feat: added google's vertexai instrumentation

8f7f36e

fix: lint issues

fecb37e

5war00p mentioned this pull request Dec 25, 2023

feat: added opentelemetry instrumentation for vertexai #279

Closed

algora-pbc bot mentioned this pull request Dec 27, 2023

🚀 Feature: VertexAI Instrumentation #249

Closed

1 task

algora-pbc bot added the 🙋 Bounty claim label Dec 27, 2023

nirga reviewed Dec 27, 2023

View reviewed changes

5war00p and others added 15 commits December 28, 2023 11:55

format: ci.yml

0ef8ceb

fix: format issues in ci.yml

a0c709f

fix: remove issues

f2f33c2

fix: formatting issues

96e6e39

fix: tabspaces

ffa8419

fix: added top_k attribute

986b652

chore: remove unwanted code and comments

e96148f

fix: vertextai version specification

a8f8e71

fix: remove unused imports

bb3f654

feat: chat instrumentation

c25bf4f

fix: assert span attribute values

1e3a62c

Restore: "feat(sdk): user feedback scores" (traceloop#254)

7ad0902

feat(semconv): added top-k (traceloop#291)

a54ae8b

feat: chat instrumentation

afdd973

fix: remove print

f202bcf

5war00p requested a review from nirga January 2, 2024 09:16

Merge branch 'main' into vertexai-instrumentation

5009e22

nirga reviewed Jan 4, 2024

View reviewed changes

5war00p added 2 commits January 4, 2024 19:26

chore: updated lock file for vertexai project

1989f8e

feat: added model_name temp solution

0a48211

Merge branch 'main' into vertexai-instrumentation

4082b55

5war00p requested a review from nirga January 4, 2024 16:06

nirga reviewed Jan 4, 2024

View reviewed changes

packages/opentelemetry-instrumentation-vertexai/pyproject.toml Outdated Show resolved Hide resolved

packages/traceloop-sdk/tests/test_vertexai_instrumentation.py Show resolved Hide resolved

5war00p added 5 commits January 5, 2024 15:08

fix: add all authors

85d757e

fix: test all span attributes

ea9603a

chore: remove google-cloud-aiplatform from pyproject as it unfits fro…

a8f5f49

…m poetry

response assertions

74e4c9b

Merge branch 'main' into vertexai-instrumentation

ea0a570

5war00p requested a review from nirga January 11, 2024 06:22

chore: lint and lock

773ca1d

nirga force-pushed the vertexai-instrumentation branch from afddbe0 to 773ca1d Compare January 11, 2024 08:55

nirga added 4 commits January 11, 2024 11:55

fix: lock file

88605e0

chore: vertex auth

46c6927

Merge branch 'main' into pr/289

51b14cd

Merge branch 'main' into pr/289

c4ecaa5

nirga force-pushed the vertexai-instrumentation branch 3 times, most recently from 94d7902 to 801b839 Compare January 11, 2024 12:08

fix: excluded URLs for vertex AI

92ab5c4

nirga force-pushed the vertexai-instrumentation branch from 801b839 to 92ab5c4 Compare January 11, 2024 12:11

5war00p and others added 3 commits January 11, 2024 18:24

fix: async wrapper missing

40f2a3e

fix: lint

3377e20

fix: sample app

6fd3a54

nirga approved these changes Jan 11, 2024

View reviewed changes

nirga merged commit 61908c9 into traceloop:main Jan 11, 2024

nina-kollman pushed a commit that referenced this pull request Aug 11, 2025

feat: google-vertexai-instrumentation (#289)

109b2a9

Co-authored-by: Nir Gazit <nirga@users.noreply.github.com>

Conversation

5war00p commented Dec 25, 2023 • edited by nirga Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

5war00p commented Dec 25, 2023

Uh oh!

nirga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

5war00p commented Jan 2, 2024

Uh oh!

nirga Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

nirga Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

5war00p Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

nirga Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

5war00p commented Jan 4, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

5war00p commented Dec 25, 2023 •

edited by nirga

Loading