refactor: dispatch async work queue in shared memory#200
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the async-work scheduling path to use a shared-memory queue (mutex/cond + intrusive list) so worker threads can directly fetch queued work without relying on main-thread dispatch, addressing a deadlock scenario where queued work never starts.
Changes:
- Switch async-work scheduling to a shared-memory queue with an Atomics-based mutex/condition variable.
- Change the async worker initialization contract to pass a shared
globalAddressintoinitWorker(...)and remove the per-taskexecuteAsyncWorkmessage path. - Update WASI threads test linker flags to export/import shared memory and async worker entrypoints.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/test/CMakeLists.txt | Enables required shared-memory + exports for WASI threads tests. |
| packages/emnapi/src/core/init.ts | Updates internal INapiModule worker init signature. |
| packages/emnapi/src/core/async-work.ts | Implements shared-memory async-work queue + worker-side dequeue/execute loop. |
| packages/core/src/worker.ts | Routes async-worker init message to the new initWorker(arg, globalAddress) signature. |
| packages/core/src/emnapi/index.d.ts | Updates public NapiModule typing for the new initWorker signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
toyobayashi
added a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm32-wasip1-threadstarget spawn async worker in JS will usepthread_create, no longer maintain a separate worker pool.