[pre-commit.ci] pre-commit autoupdate#3214
Merged
gaborbernat merged 2 commits intomainfrom Feb 5, 2024
Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.1.14 → v0.2.0](astral-sh/ruff-pre-commit@v0.1.14...v0.2.0)
for more information, see https://pre-commit.ci
Contributor
|
Umm....this commit fails the |
0cjs
added a commit
to 0cjs/tox
that referenced
this pull request
Feb 6, 2024
…oken The top-level linter setting names in pyproject.toml have changed, and while this _could_ accept the old names until they're fixed, it choses not to and fails the build. Fixing that is easy, but results in yet more failures that were not previously appearing in unchanged code. - Revert "[pre-commit.ci] pre-commit autoupdate (tox-dev#3214)" - This reverts commit 3347933.
2 tasks
Contributor
|
The four complaints we get if we fix the I have to say that (unusually for me) I agree with the robot on all of these: they are rather hard to follow due to the nesting. The first one can be relatively trivially fixed to keep the robot quiet (and it becomes slightly easier to read), but the rest are code that seems deeply convoluted enough that there's no obvious fix (at least to me) that makes it better. |
gaborbernat
pushed a commit
that referenced
this pull request
Feb 6, 2024
0cjs
added a commit
to 0cjs/tox
that referenced
this pull request
Feb 6, 2024
tool.ruff.{select,isort,ignore,per-file-ignores} will soon be deprecated in
favour of putting these under tool.ruff.lint. (See reverted PR tox-dev#3214 for
the complaint that appears in a more recent version of ruff.) Change these
now to avoid complaints later.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: