Use UTF-8 encoding when parsing pyproject.toml#1940
Merged
gaborbernat merged 5 commits intotox-dev:masterfrom Mar 3, 2021
domdfcoding:issue-1908
Merged
Use UTF-8 encoding when parsing pyproject.toml#1940gaborbernat merged 5 commits intotox-dev:masterfrom domdfcoding:issue-1908
gaborbernat merged 5 commits intotox-dev:masterfrom
domdfcoding:issue-1908
Conversation
gaborbernat
requested changes
Mar 2, 2021
Member
gaborbernat
left a comment
There was a problem hiding this comment.
The CI is still failing 🤔
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #1908
This avoids a
UnicodeDecodeErrorwhen parsingpyproject.tomlfiles containing characters on Windows. These characters may be present in a project's metadata, such as its description or an author's name.Furthermore, the TOML specification requires files to be encoded in UTF-8.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)