Skip to content

Have --packages and --all work together#273

Merged
gaborbernat merged 3 commits intotox-dev:mainfrom
kemzeb:feat/have-all-packages-options-work-together
Jul 22, 2023
Merged

Have --packages and --all work together#273
gaborbernat merged 3 commits intotox-dev:mainfrom
kemzeb:feat/have-all-packages-options-work-together

Conversation

@kemzeb
Copy link
Copy Markdown
Collaborator

@kemzeb kemzeb commented Jul 22, 2023

Resolves #161.

Had trouble using the argparse mutual exclusion API. I couldn't find an approach to get -e to be mutually exclusive to -p and -a without the latter two being mutually exclusive to each other. Therefore, I ended up doing so manually in get_options().

@kemzeb kemzeb force-pushed the feat/have-all-packages-options-work-together branch from 635beb9 to ab23143 Compare July 22, 2023 07:10
@kemzeb kemzeb force-pushed the feat/have-all-packages-options-work-together branch from 547a407 to 5031b44 Compare July 22, 2023 07:19
@gaborbernat gaborbernat force-pushed the feat/have-all-packages-options-work-together branch from 2b38700 to ea928f5 Compare July 22, 2023 16:41
for more information, see https://pre-commit.ci

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the feat/have-all-packages-options-work-together branch from ea928f5 to 06803dd Compare July 22, 2023 16:44
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 616618f into tox-dev:main Jul 22, 2023
@kemzeb kemzeb deleted the feat/have-all-packages-options-work-together branch July 22, 2023 16:59
kemzeb added a commit that referenced this pull request Jul 20, 2025
#273 removed the ability to use --include and --exclude together. I now
disagree with this change since not only was that a (accidental)
breaking change but I now see it makes sense to allow them to be used
together (e.g using pattern matching: `pidpeptree -p pytest* -e
pytest-mock`).

This change allows them to be used together and adds a few tests to
ensure that they continue to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Top level dependencies don't show when it is already listed as a subdependency when freezing

2 participants