Don't automatically enable tracing for fs feature by ginnyTheCat · Pull Request #614 · tower-rs/tower-http

ginnyTheCat · 2025-10-23T18:38:54Z

Motivation

Currently the "fs" features is exceptional in the way that it enables tracing even if the user didn't opt into this using the "tracing" feature.

Solution

Make tracing opt-in for the "fs" feature like it is for the other features as well.

jplatte · 2025-12-27T22:33:02Z

I'm a bit skeptical. I think people should get these error logs if they only enable the fs feature (I suppose we could make tracing a default feature, not sure what else this would affect).

Also: tracing is a pretty common dependency in the async Rust ecosystem, can you even get around it when depending on tower-http?

ginnyTheCat · 2025-12-28T11:34:21Z

I think people should get these error logs if they only enable the fs feature

I agree, but errors from other modules than the fs one already support running without tracing (and not getting these error logs). I have nothing against having tracing as a default feature though.

can you even get around it when depending on tower-http

Building a http server using axum only pulls in tracing when using the tower-http fs feature or reqwest serverside (since hyper-utils's client feature still pulls it in) but client-legacy doesn't.

jplatte · 2026-02-20T19:53:08Z

@tottoto what do you think?

tottoto · 2026-02-22T13:05:35Z

I’m in favor of this change. Decoupling fs from implicit tracing enables users to have more explicit control. From a feature design perspective, tracing feels like a separate concern and making it opt-in keeps responsibilities clearer.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tower-http](https://github.com/tower-rs/tower-http) | workspace.dependencies | patch | `0.6.8` → `0.6.9` | --- ### Release Notes <details> <summary>tower-rs/tower-http (tower-http)</summary> ### [`v0.6.9`](https://github.com/tower-rs/tower-http/releases/tag/tower-http-0.6.9) [Compare Source](tower-rs/tower-http@tower-http-0.6.8...tower-http-0.6.9) #### Added: - `on-early-drop`: middleware that detects when a response future or response body is dropped before completion ([#636]) Two events get hooks: the response future being dropped before the inner service produces a response, and the response body being dropped before reaching end-of-stream. Install custom callbacks with `OnEarlyDropLayer::builder()`: ```rust use http::Request; use tower_http::on_early_drop::{OnBodyDropFn, OnEarlyDropLayer}; let layer = OnEarlyDropLayer::builder() .on_future_drop(|req: &Request<()>| { let uri = req.uri().clone(); move || eprintln!("future dropped for {}", uri) }) .on_body_drop(OnBodyDropFn::new(|req: &Request<()>| { let uri = req.uri().clone(); move |parts: &http::response::Parts| { let status = parts.status; move || eprintln!("body dropped for {} status {}", uri, status) } })); ``` Or route both events through a `trace::OnFailure` hook with `EarlyDropsAsFailures`. Place this layer inside a `TraceLayer` so the emitted events inherit the request span: ```rust use tower::ServiceBuilder; use tower_http::on_early_drop::{OnEarlyDropLayer, EarlyDropsAsFailures}; use tower_http::trace::{DefaultOnFailure, TraceLayer}; let stack = ServiceBuilder::new() .layer(TraceLayer::new_for_http()) .layer(OnEarlyDropLayer::new( EarlyDropsAsFailures::new(DefaultOnFailure::default()), )); ``` - `fs`: make `AsyncReadBody::with_capacity` public ([#415]) #### Changed: - The implicit `async-compression` feature is removed ([#642]) - The implicit `tokio` feature is removed ([#628]) - `fs`: no longer auto-enables the `tracing` crate feature; enable `tracing` explicitly to restore error logging on `ServeDir` IO failures ([#614]) #### Fixed - `trace`: restore failure classification at end-of-stream ([#483]) - `follow-redirect`: support unicode URLs (swaps `iri-string` dep for `url`) ([#646]) - `fs`: reject reserved Windows DOS device names (`CON`, `COM1`, etc.) in `ServeDir` ([#663]) [#415]: tower-rs/tower-http#415 [#483]: tower-rs/tower-http#483 [#614]: tower-rs/tower-http#614 [#628]: tower-rs/tower-http#628 [#636]: tower-rs/tower-http#636 [#642]: tower-rs/tower-http#642 [#646]: tower-rs/tower-http#646 [#663]: tower-rs/tower-http#663 #### All the PRs - ci: update deny action to v2 by [@seanmonstar](https://github.com/seanmonstar) in [#627](tower-rs/tower-http#627) - chore: improve code comments clarity by [@xibeiyoumian](https://github.com/xibeiyoumian) in [#626](tower-rs/tower-http#626) - ci: Update to actions/checkout v6 by [@tottoto](https://github.com/tottoto) in [#629](tower-rs/tower-http#629) - ci: msrv resolver by [@seanmonstar](https://github.com/seanmonstar) in [#635](tower-rs/tower-http#635) - chore: Remove resolved cargo-deny config by [@tottoto](https://github.com/tottoto) in [#631](tower-rs/tower-http#631) - ci: Update to cargo-check-external-types 0.4.0 by [@tottoto](https://github.com/tottoto) in [#633](tower-rs/tower-http#633) - examples: Use typed default value clap config by [@tottoto](https://github.com/tottoto) in [#634](tower-rs/tower-http#634) - examples: Disable unused reqwest feature by [@tottoto](https://github.com/tottoto) in [#632](tower-rs/tower-http#632) - examples: Update to reqwest 0.13 by [@tottoto](https://github.com/tottoto) in [#640](tower-rs/tower-http#640) - Fix clippy warnings in warp-key-value-store example by [@jplatte](https://github.com/jplatte) in [#637](tower-rs/tower-http#637) - ci: Use Swatinem/rust-cache\@v2 to cache by [@tottoto](https://github.com/tottoto) in [#644](tower-rs/tower-http#644) - ci: Remove unused working-directory config by [@tottoto](https://github.com/tottoto) in [#645](tower-rs/tower-http#645) - Use cargo-deny graph config by [@tottoto](https://github.com/tottoto) in [#639](tower-rs/tower-http#639) - Fix: follow redirect unicode in [#646](tower-rs/tower-http#646) - doc: remove mention of deprecated bearer method in lib.rs comment by [@VojtaStanek](https://github.com/VojtaStanek) in [#641](tower-rs/tower-http#641) - Allow Unicode-3.0 license by [@tottoto](https://github.com/tottoto) in [#648](tower-rs/tower-http#648) - fix(docs): typo by [@carlocorradini](https://github.com/carlocorradini) in [#649](tower-rs/tower-http#649) - fix: remove unused GzEncoder import in decompression in [#647](tower-rs/tower-http#647) - docs: update Example server in [#652](tower-rs/tower-http#652) - Don't automatically enable tracing for fs feature by [@ginnyTheCat](https://github.com/ginnyTheCat) in [#614](tower-rs/tower-http#614) - examples: Remove unnecessary trait bound by [@tottoto](https://github.com/tottoto) in [#651](tower-rs/tower-http#651) - Remove implicit async-compression feature by [@tottoto](https://github.com/tottoto) in [#642](tower-rs/tower-http#642) - fix clippy warnings by [@alexanderkjall](https://github.com/alexanderkjall) in [#659](tower-rs/tower-http#659) - Check for reserved DOS names by [@Darksonn](https://github.com/Darksonn) in [#663](tower-rs/tower-http#663) - enable clippy for tower-http and fix current issues by [@GlenDC](https://github.com/GlenDC) in [#407](tower-rs/tower-http#407) - chore: remove implicit tokio feature by [@WaterWhisperer](https://github.com/WaterWhisperer) in [#628](tower-rs/tower-http#628) - trace: adds back call to classify\_eos on trailers by [@markdingram](https://github.com/markdingram) in [#483](tower-rs/tower-http#483) - Make AsyncReadBody::with\_capacity public by [@bouk](https://github.com/bouk) in [#415](tower-rs/tower-http#415) - examples: Use axum::body::to\_bytes by [@tottoto](https://github.com/tottoto) in [#650](tower-rs/tower-http#650) - ci: Remove unnecessary protoc setup by [@tottoto](https://github.com/tottoto) in [#665](tower-rs/tower-http#665) - feat(on-early-drop): Add middleware for client early drop detection by [@fbergero](https://github.com/fbergero) in [#636](tower-rs/tower-http#636) - chore: release tower-http 0.6.9 by [@jlizen](https://github.com/jlizen) in [#666](tower-rs/tower-http#666) #### New Contributors - [@xibeiyoumian](https://github.com/xibeiyoumian) made their first contribution in [#626](tower-rs/tower-http#626) - [@VojtaStanek](https://github.com/VojtaStanek) made their first contribution in [#641](tower-rs/tower-http#641) - [@carlocorradini](https://github.com/carlocorradini) made their first contribution in [#649](tower-rs/tower-http#649) - [@ginnyTheCat](https://github.com/ginnyTheCat) made their first contribution in [#614](tower-rs/tower-http#614) - [@alexanderkjall](https://github.com/alexanderkjall) made their first contribution in [#659](tower-rs/tower-http#659) - [@Darksonn](https://github.com/Darksonn) made their first contribution in [#663](tower-rs/tower-http#663) - [@WaterWhisperer](https://github.com/WaterWhisperer) made their first contribution in [#628](tower-rs/tower-http#628) - [@bouk](https://github.com/bouk) made their first contribution in [#415](tower-rs/tower-http#415) - [@fbergero](https://github.com/fbergero) made their first contribution in [#636](tower-rs/tower-http#636) - [@jlizen](https://github.com/jlizen) made their first contribution in [#666](tower-rs/tower-http#666) **Full Changelog**: <tower-rs/tower-http@tower-http-0.6.8...tower-http-0.6.9> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/33

ginnyTheCat force-pushed the fs-tracing branch from 2a59b49 to 2c2a565 Compare January 18, 2026 23:09

ginnyTheCat added 2 commits February 20, 2026 19:40

Don't automatically enable tracing for fs feature

624a7ef

Clarify behavior in docs

c413338

ginnyTheCat force-pushed the fs-tracing branch from 2c2a565 to c413338 Compare February 20, 2026 18:40

jplatte reviewed Feb 22, 2026

View reviewed changes

Comment thread tower-http/src/services/fs/serve_dir/mod.rs Outdated

Comment thread tower-http/src/services/fs/serve_dir/open_file.rs Outdated

Use _err directly instead of let _

0528e75

tottoto approved these changes Feb 23, 2026

View reviewed changes

jplatte reviewed Mar 6, 2026

View reviewed changes

Comment thread tower-http/src/services/fs/serve_dir/open_file.rs Outdated

Revert tracing field name

946405a

jplatte enabled auto-merge (squash) March 6, 2026 17:56

jplatte merged commit 86f1499 into tower-rs:main Mar 6, 2026
11 checks passed

ginnyTheCat deleted the fs-tracing branch March 6, 2026 19:24

barjin pushed a commit to apify/tower-http that referenced this pull request Mar 11, 2026

Don't automatically enable tracing for fs feature (tower-rs#614)

402b80c

jlizen mentioned this pull request May 5, 2026

chore: release tower-http 0.6.9 #666

Merged

greptile-apps Bot mentioned this pull request Jun 16, 2026

fix(deps): update rust crate tower-http to 0.7 readur/readur#733

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't automatically enable tracing for fs feature#614

Don't automatically enable tracing for fs feature#614
jplatte merged 4 commits into
tower-rs:mainfrom
ginnyTheCat:fs-tracing

ginnyTheCat commented Oct 23, 2025

Uh oh!

jplatte commented Dec 27, 2025

Uh oh!

ginnyTheCat commented Dec 28, 2025 •

edited

Loading

Uh oh!

jplatte commented Feb 20, 2026 •

edited

Loading

Uh oh!

tottoto commented Feb 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ginnyTheCat commented Oct 23, 2025

Motivation

Solution

Uh oh!

jplatte commented Dec 27, 2025

Uh oh!

ginnyTheCat commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jplatte commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tottoto commented Feb 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ginnyTheCat commented Dec 28, 2025 •

edited

Loading

jplatte commented Feb 20, 2026 •

edited

Loading