fix: strip port from pasted URLs, sanitize RNode/UDP hosts by torlando-tech · Pull Request #538 · torlando-tech/columba

torlando-tech · 2026-02-23T22:43:04Z

Summary

Follow-up to #533, addressing Greptile review feedback:

Strip trailing :port from hostnames (e.g. http://example.com:8080 → example.com)
Use cleaned values from validateHostname() in RNode TCP and UDP entityToConfig() branches (previously discarded)
Strip http:// and https:// in UI text field onValueChange handlers for immediate visual feedback

Test plan

2 new unit tests for port stripping (URL with port, bare hostname with port)
All existing InputValidator, InterfaceRepository, and InterfaceManagementViewModel tests pass
Manual: paste http://example.com:8080 in TCP host field, verify it becomes example.com

🤖 Generated with Claude Code

…vel stripping Address Greptile review feedback on #533: - Strip trailing :port from hostnames (e.g. "example.com:8080" → "example.com") - Use cleaned values from validateHostname() in RNode TCP and UDP entityToConfig branches - Strip http:// and https:// in UI text field onValueChange handlers for immediate feedback Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

greptile-apps · 2026-02-23T22:45:51Z

Greptile Summary

Addresses Greptile review feedback from #533 by implementing a safer port-stripping strategy using colon count rather than regex matching. The PR correctly fixes the previously identified IPv6 corruption issue by checking if a string has exactly one colon before applying port stripping logic.

Key improvements:

Port stripping now uses colon count (== 1) to distinguish hostname:port from IPv6 addresses (multiple colons)
Cleaned hostname values from validateHostname() are now properly used in InterfaceRepository instead of being discarded
UI text fields strip http:// and https:// prefixes immediately for better user feedback
Comprehensive test coverage added for port stripping and IPv6 protection

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation correctly addresses the previous review feedback with a sound algorithmic approach (colon counting), includes comprehensive test coverage for edge cases, and properly integrates the cleaned values throughout the codebase. The logic is defensive and well-documented.
No files require special attention

Important Files Changed

Filename	Overview
app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt	Improved port stripping logic using colon count instead of regex to safely handle IPv6 addresses
app/src/main/java/com/lxmf/messenger/repository/InterfaceRepository.kt	Now uses cleaned values from `validateHostname()` for RNode TCP and UDP hosts instead of discarding them
app/src/main/java/com/lxmf/messenger/ui/components/InterfaceConfigDialog.kt	Added UI-level URL scheme stripping for immediate visual feedback when users paste URLs
app/src/test/java/com/lxmf/messenger/util/validation/InputValidatorTest.kt	Added comprehensive tests for port stripping and IPv6 address protection

_{Last reviewed commit: 0db9d43}

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt

Add IPV6_REGEX check before port-stripping to prevent corrupting IPv6 addresses like "2001:db8::1" where the trailing ":1" looks like a port number. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

torlando-tech · 2026-02-23T22:59:57Z

@greptileai

app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt

greptile-apps

_{4 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt

greptile-apps · 2026-02-23T23:03:08Z

app/src/test/java/com/lxmf/messenger/util/validation/InputValidatorTest.kt

+    fun `validateHostname - does not strip segments from IPv6 address`() {
+        // IPv6 like "2001:db8::1" ends with ":1" which could look like a port
+        val validIPv6 = listOf("2001:db8:85a3:0:0:8a2e:370:7334", "fe80:0:0:0:0:0:0:1")
+        validIPv6.forEach { ipv6 ->
+            val result = InputValidator.validateHostname(ipv6)
+            assertTrue("$ipv6 should be valid", result is ValidationResult.Success)
+            assertEquals(ipv6, result.getOrNull())
+        }
+    }


Missing test for ::1 and other compressed IPv6 forms

Test only covers full/uncompressed IPv6. Missing critical cases:

::1 (loopback)

fe80::1 (link-local)

::ffff:192.0.2.1 (IPv4-mapped)

These would fail with current implementation due to incomplete IPV6_REGEX.

Prompt To Fix With AI

This is a comment left during a code review. Path: app/src/test/java/com/lxmf/messenger/util/validation/InputValidatorTest.kt Line: 289-297 Comment: Missing test for `::1` and other compressed IPv6 forms Test only covers full/uncompressed IPv6. Missing critical cases: - `::1` (loopback) - `fe80::1` (link-local) - `::ffff:192.0.2.1` (IPv4-mapped) These would fail with current implementation due to incomplete `IPV6_REGEX`. How can I resolve this? If you propose a fix, please make it concise.

torlando-tech · 2026-02-23T23:15:03Z

@greptileai

Compressed IPv6 like "::1" or "fe80::1" aren't matched by IPV6_REGEX and would be corrupted by port stripping. Instead of fixing the regex, use a simpler invariant: IPv6 always has multiple colons, hostname:port has exactly one. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

torlando-tech · 2026-02-24T02:18:12Z

@greptileai

greptile-apps bot reviewed Feb 23, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt Outdated Show resolved Hide resolved

fix: guard port stripping against unbracketed IPv6 addresses

8b1193c

Add IPV6_REGEX check before port-stripping to prevent corrupting IPv6 addresses like "2001:db8::1" where the trailing ":1" looks like a port number. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry bot reviewed Feb 23, 2026

View reviewed changes

app/src/main/java/com/lxmf/messenger/util/validation/InputValidator.kt Show resolved Hide resolved

greptile-apps bot reviewed Feb 23, 2026

View reviewed changes

torlando-tech mentioned this pull request Feb 23, 2026

fix: use colon count instead of IPv6 regex for port-stripping guard #539

Merged

3 tasks

torlando-tech merged commit f19ff63 into release/v0.8.x Feb 24, 2026
2 checks passed

torlando-tech deleted the fix/hostname-port-strip-v0.8.x branch February 24, 2026 02:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: strip port from pasted URLs, sanitize RNode/UDP hosts#538

fix: strip port from pasted URLs, sanitize RNode/UDP hosts#538
torlando-tech merged 3 commits intorelease/v0.8.xfrom
fix/hostname-port-strip-v0.8.x

torlando-tech commented Feb 23, 2026

Uh oh!

greptile-apps bot commented Feb 23, 2026 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

torlando-tech commented Feb 23, 2026

Uh oh!

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

greptile-apps bot Feb 23, 2026

Uh oh!

torlando-tech commented Feb 23, 2026

Uh oh!

torlando-tech commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

torlando-tech commented Feb 23, 2026

Summary

Test plan

Uh oh!

greptile-apps bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

torlando-tech commented Feb 23, 2026

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

torlando-tech commented Feb 23, 2026

Uh oh!

torlando-tech commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps bot commented Feb 23, 2026 •

edited

Loading