Greptile Summary

This PR fixes a crash (IllegalStateException) caused by users entering full URLs (e.g., http://rns.soon.it) as TCP hostnames. The fix strips http:// and https:// scheme prefixes (and any path component) in InputValidator.validateHostname(), and propagates the cleaned value through both the repository layer (fixing existing poison data on read) and the ViewModel layer (updating UI state so subsequent saves persist the sanitized value).

• InputValidator.validateHostname() now strips URI scheme prefixes, trailing slashes, and path components before validation
• InterfaceRepository.entityToConfig() uses the cleaned hostname from ValidationResult.Success for TCPClient and TCPServer types, sanitizing existing bad data on read
• InterfaceManagementViewModel.validateConfigState() writes the cleaned hostname back to _configState so the UI reflects the sanitized value
• 5 new unit tests cover scheme stripping for http, https, trailing slashes, paths, and IP addresses
• Issue: The RNode (TCP mode) and UDP interface branches in entityToConfig() still use the old pattern that discards the cleaned value — these should be updated for consistency to fully close the poison-data bug across all interface types

Confidence Score: 3/5

• The core fix is correct and well-tested for TCPClient/TCPServer, but the same sanitization was not applied to RNode and UDP interface types, leaving a gap.
• Score of 3 reflects that the primary fix is sound and backed by tests, but the inconsistent application across interface types in entityToConfig() means the poison-data issue is not fully resolved. The RNode TCP-mode and UDP branches still pass raw hostnames/IPs, which could trigger the same crash if users paste URLs there.
• Pay close attention to app/src/main/java/com/lxmf/messenger/repository/InterfaceRepository.kt — specifically the RNode (line 274-280) and UDP (lines 332-346) validation branches that still discard the cleaned hostname.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["User enters hostname\n(e.g., http://rns.soon.it)"] --> B["InputValidator.validateHostname()"]
    B --> C["Strip scheme prefix\n(http:// / https://)"]
    C --> D["Strip trailing slash\nand path components"]
    D --> E{"Validate cleaned\nhostname"}
    E -->|Valid| F["ValidationResult.Success\n(cleaned value)"]
    E -->|Invalid| G["ValidationResult.Error"]

    F --> H["ViewModel:\nWrite back to _configState\n(targetHost / listenIp)"]
    F --> I["Repository:\nentityToConfig uses\ncleaned value"]

    H --> J["User sees sanitized\nhostname in UI"]
    I --> K["InterfaceConfig created\nwith clean hostname"]

    G --> L["Error shown to user"]

    style C fill:#d4edda,stroke:#28a745
    style D fill:#d4edda,stroke:#28a745
    style H fill:#d4edda,stroke:#28a745
    style I fill:#fff3cd,stroke:#ffc107

_{Last reviewed commit: 7e2138f}