fix: remove OLED references and fix flaky CI submodule checkout#509
fix: remove OLED references and fix flaky CI submodule checkout#509torlando-tech merged 2 commits intomainfrom
Conversation
The framebuffer feature works on all RNode display types, not just OLEDs. Addresses Greptile review feedback from PR #499. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
actions/checkout sets a GITHUB_TOKEN-scoped auth header for all github.com URLs. Since the token is scoped to columba only, cloning the LXST-kt submodule sends an unauthorized token which GitHub rejects — even though LXST-kt is public. persist-credentials: false prevents the auth header from being set, allowing anonymous clones of public submodules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Greptile SummaryThis PR makes two types of changes: fixing a CI authentication issue and cleaning up terminology. CI Fix: Added Terminology Cleanup: Removed "OLED" references from RNode display-related strings and comments in favor of the generic term "display"/"screen", since the framebuffer feature works on all RNode display types (not just OLEDs). Changes include:
Note: ReticulumConfig.kt includes incidental enum formatting changes (lines 239-241, 252-254) from IDE auto-format. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: a3839dc |
| enum class DiscoveryScope( | ||
| val value: String, | ||
| ) { |
There was a problem hiding this comment.
Unintended IDE auto-format changed enum constructor to multi-line format (previous: enum class DiscoveryScope(val value: String)). Same for InterfaceMode on line 252.
Prompt To Fix With AI
This is a comment left during a code review.
Path: reticulum/src/main/java/com/lxmf/messenger/reticulum/model/ReticulumConfig.kt
Line: 239-241
Comment:
Unintended IDE auto-format changed enum constructor to multi-line format (previous: `enum class DiscoveryScope(val value: String)`). Same for `InterfaceMode` on line 252.
How can I resolve this? If you propose a fix, please make it concise.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
persist-credentials: falseto allactions/checkoutsteps that usesubmodules: recursiveSupersedes #499 and addresses Greptile review feedback.
Changes
OLED reference cleanup (addresses Greptile feedback on #499)
ReviewConfigStep.kt:526ReticulumConfig.kt:144ReticulumConfig.kt:164RNodeWizardViewModel.kt:188CI fix
actions/checkoutsets aGITHUB_TOKEN-scoped auth header for allgithub.comURLs. Since the token is scoped tocolumbaonly, cloning the publicLXST-ktsubmodule sends an unauthorized token which GitHub rejects.persist-credentials: falseprevents the auth header from being set, allowing anonymous clones.This caused 3/4 Kotlin test shards + Python tests to fail on PR #499 (and likely other fork PRs).
Test plan
🤖 Generated with Claude Code