Skip to content

ReviewConfigStep.kt - remove the word OLED#499

Merged
torlando-tech merged 1 commit intotorlando-tech:mainfrom
serialrf433:patch-1
Feb 20, 2026
Merged

ReviewConfigStep.kt - remove the word OLED#499
torlando-tech merged 1 commit intotorlando-tech:mainfrom
serialrf433:patch-1

Conversation

@serialrf433
Copy link
Copy Markdown
Contributor

It is the same on non-oled screens

It is the same on non-oled screens
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

Removes the word "OLED" from the user-facing description of the RNode display logo toggle in ReviewConfigStep.kt. The text now reads "Show Columba logo on RNode's display when connected" instead of "Show Columba logo on RNode's OLED display when connected", since the framebuffer feature works on all RNode display types, not just OLED screens.

  • Single string change in ReviewConfigStep.kt line 526 — removes "OLED" from a Text composable's content
  • Note: internal code comments in ReticulumConfig.kt (lines 144, 164) and RNodeWizardViewModel.kt (line 188) still reference "OLED" — consider updating those comments for consistency in a follow-up

Confidence Score: 5/5

  • This PR is safe to merge — it only changes a single user-facing string with no functional impact.
  • The change is a trivial one-word removal from a UI description string. There is zero risk of introducing bugs, regressions, or behavioral changes.
  • No files require special attention.

Important Files Changed

Filename Overview
app/src/main/java/com/lxmf/messenger/ui/screens/rnode/ReviewConfigStep.kt Single-word removal ("OLED") from a user-facing description string. No logic, syntax, or functional impact.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["ReviewConfigStep UI"] -->|"enableFramebuffer toggle"| B["RNodeWizardViewModel"]
    B -->|"updateEnableFramebuffer()"| C["RNode Config State"]
    C -->|"enableFramebuffer: Boolean"| D["ReticulumConfig.RNode"]
    style A fill:#e8f5e9,stroke:#4caf50
    A -.- E["'Show Columba logo on\nRNode's display when connected'\n(OLED removed from text)"]
    style E fill:#fff3e0,stroke:#ff9800
Loading

Last reviewed commit: fdadcfb

@serialrf433
Copy link
Copy Markdown
Contributor Author

@torlando-tech
Could you add to this PR what greptile mentioned?

Note: internal code comments in ReticulumConfig.kt (lines 144, 164) and RNodeWizardViewModel.kt (line 188) still reference "OLED" — consider updating those comments for consistency in a follow-up

torlando-tech added a commit that referenced this pull request Feb 19, 2026
The framebuffer feature works on all RNode display types, not just OLEDs.
Addresses Greptile review feedback from PR #499.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@torlando-tech torlando-tech merged commit 676205d into torlando-tech:main Feb 20, 2026
15 of 23 checks passed
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants