Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Greptile Summary

Fixed a bug where USB-connected RNodes incorrectly triggered Bluetooth permission requests. The fix adds "usb" to the exclusion check in requiresBluetooth() alongside the existing "tcp" check.

• Updated InterfaceDao.kt:200 to exclude both "tcp" and "usb" connection modes from requiring Bluetooth
• Added 2 new unit tests covering USB RNode scenarios (single USB RNode, combined USB+TCP RNodes)
• Updated documentation comment to clarify that both USB and TCP connections don't need Bluetooth
• Minor formatting improvements (expression body syntax)

The logic change is correct: USB RNodes use the Android USB Host API, not Bluetooth, so they should not trigger permission requests.

Confidence Score: 5/5

• Safe to merge - straightforward bug fix with comprehensive test coverage
• Single-line logic fix addresses the root cause correctly, all existing tests pass, new tests provide complete coverage of USB scenarios, and the change is well-documented
• No files require special attention

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    Start[Interface enabled?] -->|Yes| CheckType{Interface Type?}
    Start -->|No| NoPermission[No Bluetooth needed]
    
    CheckType -->|AndroidBLE| NeedBT[Requires Bluetooth]
    CheckType -->|RNode| ParseJSON[Parse connection_mode from JSON]
    CheckType -->|Other| NoPermission
    
    ParseJSON -->|JSON Error| NeedBT
    ParseJSON -->|Success| CheckMode{connection_mode value?}
    
    CheckMode -->|tcp| NoPermission
    CheckMode -->|usb| NoPermission
    CheckMode -->|classic| NeedBT
    CheckMode -->|ble| NeedBT
    CheckMode -->|missing/empty| NeedBT
    
    style NeedBT fill:#ffcccc
    style NoPermission fill:#ccffcc
    style CheckMode stroke:#ff6600,stroke-width:3px

_{Last reviewed commit: 99e533b}