Skip to content

fix: make announce filter dialog scrollable on short displays#482

Merged
torlando-tech merged 1 commit intorelease/v0.8.xfrom
fix/announce-filter-dialog-scrollable
Feb 18, 2026
Merged

fix: make announce filter dialog scrollable on short displays#482
torlando-tech merged 1 commit intorelease/v0.8.xfrom
fix/announce-filter-dialog-scrollable

Conversation

@torlando-tech
Copy link
Copy Markdown
Owner

Summary

  • Adds verticalScroll to the NodeTypeFilterDialog column so all 9 checkbox rows (3 node types + audio + 5 interface types) are accessible on shorter phone screens

Closes #480

Test plan

  • Open the announce filter dialog on a short-display device (or emulator with small screen)
  • Verify all checkboxes (including the bottom interface type filters) are reachable by scrolling
  • Verify the dialog still looks correct on larger displays (no unnecessary scrollbar)

🤖 Generated with Claude Code

The NodeTypeFilterDialog had 9 checkbox rows plus headers that could
overflow on shorter phone screens. Wraps the dialog Column in
verticalScroll so all filter options are accessible.

Closes #480

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

Added verticalScroll modifier to the NodeTypeFilterDialog Column to enable scrolling on short displays where all 9 checkbox options (3 node types + audio + 5 interface types) may not fit on screen.

  • Properly imported rememberScrollState and verticalScroll from Compose foundation
  • Minimal, focused change that addresses the accessibility issue on short displays
  • No impact on larger displays where content already fits

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Simple UI fix adding vertical scroll to a dialog Column - correctly implemented with proper imports and no logical issues
  • No files require special attention

Important Files Changed

Filename Overview
app/src/main/java/com/lxmf/messenger/ui/screens/AnnounceStreamScreen.kt Added vertical scrolling to dialog Column to make all 9 filter checkboxes accessible on short displays

Last reviewed commit: 238c7f9

@torlando-tech torlando-tech merged commit 7f04519 into release/v0.8.x Feb 18, 2026
14 checks passed
@torlando-tech torlando-tech deleted the fix/announce-filter-dialog-scrollable branch February 18, 2026 02:53
@torlando-tech torlando-tech linked an issue Feb 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Announces filter have a fifth box with no description

1 participant