Remove xcshareddata folder from gitignore#319
Merged
joeblau merged 1 commit intotoptal:masterfrom Mar 25, 2017
Merged
Conversation
This folder contains data that is intended to be shared. Steps to create it: Product > Scheme > Manage Schemes... Mark the "Shared" checkbox
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 18
Lines 382 382
=====================================
Hits 382 382Continue to review full report at Codecov.
|
Contributor
|
Just looking at this, I've realized that GitHub already has template for Xcode. What we should do is add this to the /data/Patch directory under Xcode.patch which will amend GitHub's. We should also remove this file. |
joeblau
added a commit
that referenced
this pull request
Mar 25, 2017
* master: Added 25 Tempaltes from https://github.com/github/gitignore (#322) Updated master template list (#321) Remove xcshareddata folder from gitignore (#319) Updated master template list Add sonar lint (#318)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This folder contains data that are intended to be shared.
Steps to create it:
Product > Scheme > Manage Schemes...
Mark the "Shared" checkbox