Skip to content

Add keySelectorCreator option#82

Merged
toomuchdesign merged 2 commits intomasterfrom
key-selector-creator-option
Jun 22, 2019
Merged

Add keySelectorCreator option#82
toomuchdesign merged 2 commits intomasterfrom
key-selector-creator-option

Conversation

@toomuchdesign
Copy link
Copy Markdown
Owner

@toomuchdesign toomuchdesign commented Jun 19, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

What is the current behaviour? (You can also link to an open issue here)

#73

What is the new behaviour?

Add keySelectorCreator option to provide an hook to dynamically generate keySelectors based on provided inputSelectors, resultFunc and keySelector.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

This is a partial release of a wider feature aiming to provide a way of composing automagically cachedSelectors. See:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 19, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 448be75 on key-selector-creator-option into e44ce2d on master.

@toomuchdesign toomuchdesign force-pushed the key-selector-creator-option branch 4 times, most recently from e485757 to 8e8f6e9 Compare June 21, 2019 16:51
@toomuchdesign toomuchdesign force-pushed the key-selector-creator-option branch from 8e8f6e9 to cac3298 Compare June 21, 2019 21:21
@toomuchdesign toomuchdesign mentioned this pull request Jun 21, 2019
2 tasks
@toomuchdesign toomuchdesign force-pushed the key-selector-creator-option branch from cac3298 to 448be75 Compare June 22, 2019 08:09
@toomuchdesign toomuchdesign merged commit 0f0e921 into master Jun 22, 2019
@toomuchdesign toomuchdesign deleted the key-selector-creator-option branch June 22, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants