Conversation
d93a9bd to
e7acb98
Compare
0677371 to
770daca
Compare
770daca to
5d78aaf
Compare
src/combineKeySelectors.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| function combineKeySelectors({inputSelectors = [], keySelector}) { | |||
| const keySelectors = inputSelectors | |||
| .filter(entry => entry.hasOwnProperty('keySelector')) | |||
There was a problem hiding this comment.
I think it will more performant if you will filter inputSelectors by typeof keySelector === 'function' here.
c77a340 to
484c1e7
Compare
|
Before considering this PR mergeable, I'd like to address the following issue. I write it down here to not keep everything floating in my head.
|
3b5824c to
648688a
Compare
|
Most of the open points of this PR are now solved:
We'll open a new PR in case we decided to include a |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behaviour? (You can also link to an open issue here)
#73
What is the new behaviour?
Try to provide some additional optional runtime context information to
keySelectorfunction to allow keySelectors autogeneration based on providedinputSelectorsandresultFunc.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Hopefully not.
Other information:
Please check if the PR fulfills these requirements: