Skip to content

Replace dash - with minus −#15

Merged
tomtung merged 2 commits into
tomtung:masterfrom
Atcold:patch-1
Jul 21, 2021
Merged

Replace dash - with minus −#15
tomtung merged 2 commits into
tomtung:masterfrom
Atcold:patch-1

Conversation

@Atcold

@Atcold Atcold commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@Atcold

Atcold commented Jul 15, 2021

Copy link
Copy Markdown
Contributor Author

Any update on this?

@tomtung tomtung merged commit 0c2bab4 into tomtung:master Jul 21, 2021
@Atcold Atcold deleted the patch-1 branch July 21, 2021 20:11
@Atcold

Atcold commented Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for merging!

tomtung added a commit that referenced this pull request Apr 5, 2022
tomtung added a commit that referenced this pull request Apr 5, 2022
@Siedlerchr

Copy link
Copy Markdown
Contributor

This is breaking all our tests. JabRef/jabref#8639
I would suggest to maybe only replace this in math mode?
Consider an author like: al-Khw{\\={a}}rizm{\\={i}} which previously was equal to al-Khwārizmī with a normal hyphen-dash (U+002D) and now it would be rendered with a minus sign (U+2212) which is wrong.

@tomtung

tomtung commented Apr 11, 2022

Copy link
Copy Markdown
Owner

Ah good point... Currently we "cheat" by not considering math v.s. non-math mode:

To do this properly, we need to support parsing for math mode blocks, which is non-trivial. Maybe for now the best thing to do is to leave - as-is, and only escaping \textminus to the Unicode minus sign?

@Siedlerchr

Copy link
Copy Markdown
Contributor

Yes! I think this would be the easiest solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants