Skip to content

Improving UIButton and UITextfield support#350

Merged
Stunner merged 7 commits intotombenner:masterfrom
antobito11:master
Apr 25, 2016
Merged

Improving UIButton and UITextfield support#350
Stunner merged 7 commits intotombenner:masterfrom
antobito11:master

Conversation

@antobito11
Copy link
Copy Markdown
Contributor

Adding support for tint-color in UITextfield.
Adding support for background-color in UIButton without using a color based image that was causing problems with drop shadow and corner-radius.

Gomez and others added 3 commits April 4, 2016 08:37
… of UIButton and not setBackgroundImage:forState:
Updating the README file to document support to UITextField tint-color and UIButton background-colour-normal.
@Stunner
Copy link
Copy Markdown
Collaborator

Stunner commented Apr 23, 2016

This change seems to have caused a regression for the -[NUIButtonRendererBackgroundColorTests testBackgroundColor] test. If you fix the regression I'll be happy to take a look.

@antobito11
Copy link
Copy Markdown
Contributor Author

antobito11 commented Apr 25, 2016

I have already updated the regression test for both UIButton and UITextField. Additionally, I added support for UIActivityIndicatorView with its own test as well. Let me know if I need to update something else.

@Stunner
Copy link
Copy Markdown
Collaborator

Stunner commented Apr 25, 2016

Looks good to me, but just a word of advice for next time: Please try to keep pull requests as small and modular as possible. I noticed 13 hours ago changes for UIActivityIndicatorView also snuck in. In order to avoid that, please place changes for other components in a new branch (as opposed to merely adding onto your master branch) and submit a new pull request for that branch. You can reference pull requests made by alexeyt820 as an example of how it should be done. The reason we want to do it this way is because it reduces the risk associated with merging in a pull request when it's smaller. Also if you happened to introduce something that doesn't get past review with the UIActivityIndicatorView changes, the entire PR would be placed on hold rather than just the relevant part.

@Stunner Stunner merged commit 211ad22 into tombenner:master Apr 25, 2016
antobito11 added a commit to antobito11/nui that referenced this pull request Jul 6, 2016
Merge pull request tombenner#350 from antobito11/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants