Skip to content

Allow setting numberOfLines on UILabel through NUI#338

Merged
Stunner merged 1 commit intotombenner:masterfrom
alexeyt820:PRUITextFieldNumberOfLines
Mar 15, 2016
Merged

Allow setting numberOfLines on UILabel through NUI#338
Stunner merged 1 commit intotombenner:masterfrom
alexeyt820:PRUITextFieldNumberOfLines

Conversation

@alexeyt820
Copy link
Copy Markdown

No description provided.

@Stunner
Copy link
Copy Markdown
Collaborator

Stunner commented Mar 15, 2016

Looks good thanks!

Stunner added a commit that referenced this pull request Mar 15, 2016
Allow setting numberOfLines on UILabel through NUI.
@Stunner Stunner merged commit 627a600 into tombenner:master Mar 15, 2016
@timbodeit
Copy link
Copy Markdown
Collaborator

LGTM.
Any reason for naming this attribute text-line-clamp instead of number-of-lines though?

@alexeyt820
Copy link
Copy Markdown
Author

Reason for naming - to be similar with web-kit css style -webkit-line-clamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants