Skip to content

Allow to set keyboard appearance on UITextField#337

Merged
Stunner merged 3 commits intotombenner:masterfrom
alexeyt820:PRUITextFieldKeyboardAppearance
Mar 15, 2016
Merged

Allow to set keyboard appearance on UITextField#337
Stunner merged 3 commits intotombenner:masterfrom
alexeyt820:PRUITextFieldKeyboardAppearance

Conversation

@alexeyt820
Copy link
Copy Markdown

No description provided.

@alexeyt820
Copy link
Copy Markdown
Author

I believe if value set to default NUIConverter will return UIKeyboardAppearanceDefault, because none if/else branches will be triggered (I modeled behavior after toControlContentVerticalAlignment). Or you are suggesting to raise exception?

@Stunner
Copy link
Copy Markdown
Collaborator

Stunner commented Mar 14, 2016

Ah I see. That works.

I was thinking of having all values having to be explicitly specified, and if it was misspelt or an invalid value (i.e. blue) it should merely not set that property's value and move on (don't even return a default, just avoid setting the property and move on). But considering this is a common pattern found throughout the codebase I think it fine for now. Although, I would like to change it sometime in the future.

Good job on conforming to coding conventions in this project, by the way.

Stunner added a commit that referenced this pull request Mar 15, 2016
Add capability to set keyboard appearance of UITextField/UITextView.
@Stunner Stunner merged commit d776c81 into tombenner:master Mar 15, 2016
@timbodeit
Copy link
Copy Markdown
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants