Exclude-views/subviews Comma Separated List Fix#312
Exclude-views/subviews Comma Separated List Fix#312timbodeit merged 1 commit intotombenner:masterfrom
Conversation
|
Please have a look at the Readme. The way I see it, your changes would break the existing and documented behavior and force everybody to add a single space before and after the comma. Nonetheless a pull-request, that adds support for spaces (without breaking existing notations) in this comma separated list would be very welcome. |
|
In my exclude-subviews, I am using a comma separated list without spaces.
The problem, as pointed out by frapaa in #269 is that the NUIParserDelegate.m is adding in extra spaces around the commas. So:
is converted to This happens on line 48 of NUIParserDelegate.m Because the exclude-subviews string now has extra spaces in it, the logic on UIView+NUI.m lines 52 and 66 doesn't work. So my pull request was to address this issue by splitting the exclude-subviews string with a " , " instead of ",". I think this is ultimately the error that is being reported in issues #224 , #269 and #299 |
|
I'm sorry. Looks good to me. |
Exclude-views/subviews Comma Separated List Fix
|
For future reference: In my eyes the parser needs some work as
is not exactly ideal. Also this is probably something we should add a unit test for. |
A comma separated list of exclude-views or exclude-subviews wasn't working correctly. This is a quick fix for that.