Conversation
|
@tombenner @Stunner Please have a look over this. |
|
LGTM, but it'd be good to get another pair of eyes on it, too 👍 |
|
Encountered this error when running Remove |
b13ceb2 to
d0a53f2
Compare
|
I wouldn't remove the entire lockfile, as its a good reference what versions were actually used and causes the CI server to use the same ones. The reason this was throwing an error is that the Podfile.lock was outdated. The Podfile was specifying to use the latest commit on master of tombenner/NUIParse. However the lockfile specified a specific version, that is older than the current one. What I did instead was to remove the git url from the Podfile and update the Podfile.lock |
|
Interesting, I thought the Podfile.lock was always generated based on the contents of the Podfile. I thought it was a one way street. Didn't think the information of the Podfile.lock would matter much given that a pod install would overwrite it anyway. |
|
That's the entire purpose of the lockfile. It gives you a way of making sure everybody is using the same versions without checking in all of the dependency code. Instead when you want to update the used version of a specific pod, commit those changes to the Podfile.lock |
|
Good to know. I had always been doing that via the |
|
Well normally I use a combination of the two. The Podfile and more important the podspecs of any Pods could have a loose version requirement (e.g. by using the ~> operator) and the Lockfile would help me get the exact version I was using in previous development when checking out an older commit. |
Personally I'm not a big fan of including copies of the full source of all the dependencies inside a frameworks repository.
In my opinion pull requests should be as small as possible, focus on the actual changes and not be cluttered by code changes from dependencies.
The
.travis.ymlalready includes apod installcall and the Readme already advises the user to runpod installmanually before trying out the Demo project.Alongside this, I added a few other things to the
.gitignorethat I find reasonable and removed an xccheckout file.