Skip to content

Fix test suite#308

Merged
timbodeit merged 5 commits intotombenner:masterfrom
timbodeit:fixTestSuite
Nov 6, 2015
Merged

Fix test suite#308
timbodeit merged 5 commits intotombenner:masterfrom
timbodeit:fixTestSuite

Conversation

@timbodeit
Copy link
Copy Markdown
Collaborator

@timbodeit timbodeit commented Nov 3, 2015

  • Update pods for Demo project (lockfile only) to resolve issues with old version of FBSnapshotTestCase.
    This fixes FBSnapshotTestCase Fails Compilation #302
  • Fix testSetPadding
    Test case was testing for padding equals 5 when test nss file specifies 7.
  • Update reference images for NUIBarButtonSnapshotTests
    Replaced @2x images as drawing seems to have slightly changed.
    Added @1x and @3x images to allow running the tests on iPad 2 and iPhone 6 Plus.
  • Update CocoaPods to the latest version before building on Travis (just in case)
  • Add badges for build status, pod version, license and platform to the readme.

@timbodeit
Run pod update on Demo project
43d2870
@timbodeit
Fix testSetPadding
0a7ae5d 
The nss specifies titleInsets of 7.
Update the insets variable to have 7 to all sides instead of 5.
@timbodeit
Update reference images
34393fc 
Replace @2x images as drawing seems to have slightly
changed in newer versions of iOS.
Add @1x and @3x images to allow the tests to be run
on iPhone 6 Plus and iPad 2.
@timbodeit
Install latest CocoaPods version on Travis
d0a15ec
@timbodeit
Add build status, pod version, license and platform tags to readme
4b01aa6
@timbodeit timbodeit mentioned this pull request Nov 3, 2015
Closed
@timbodeit
Copy link
Copy Markdown
Collaborator Author

timbodeit commented Nov 5, 2015

@tombenner @Stunner Please have a look over this.

@tombenner
Copy link
Copy Markdown
Owner

tombenner commented Nov 6, 2015

LGTM, thanks! 👍

@Stunner
Copy link
Copy Markdown
Collaborator

Stunner commented Nov 6, 2015

Looking good man. I think it's ready to merge in.

timbodeit added a commit that referenced this pull request Nov 6, 2015
@timbodeit
Merge pull request #308 from timbodeit/fixTestSuite
267436c 
Fix test suite
@timbodeit timbodeit merged commit 267436c into tombenner:master Nov 6, 2015
@timbodeit timbodeit deleted the fixTestSuite branch November 6, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FBSnapshotTestCase Fails Compilation

3 participants

@timbodeit @tombenner @Stunner