Merged
Conversation
…entation notifications
In my timing tests, walking the visible views was about the same amount of time as using registered objects. Since using registered objects was causing memory leaks and did not handle all stylesheet changes, it made sense to remove them.
Contributor
Author
|
@tombenner, this pull request is the culmination of my parsing work. I have tried the new Let me know if you have any questions or anything stopping this pull request from getting merged. |
Owner
|
This is just fantastic, @phatmann. Many thanks for this, as well as your other contributions! This is a huge boon to everyone who uses NUI. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supports
@mediaqueries with the parameters(orientation: ipad | iphone)or(device: landscape | portrait). They can be combined withand. A@mediablock can contain a combination of variable definitions and rules. The updated README contains examples.Also included:
@mediaquery I needed some way to re-render. However, the registeredObjects array was causing memory leaks and did not handle the case where a stylesheet change affected unrendered objects. I did some timing tests and discovered that walking the visible views took the same amount of time as using registeredObjects. Therefore I removed the registeredObjects functionality, both for handling@mediaorientation changes and auto-update.Fixes #3 and #180.